Refactoring & testing utils/authentication.py #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corey-nm
requested review from
bfineran,
kylesayrs,
rahul-tuli,
KSGulin and
dbogunowicz
corey-nm
commented
Aug 26, 2022
| @@ -124,24 +55,63 @@ def get_auth_header( | |||
|
|
|||
| Currently only 'public' authentication type is supported. | |||
|
|
|||
| :param authentication_type: authentication type for generating token | |||
There was a problem hiding this comment.
I removed authentication_type as a parameter since there was only 1 valid type and nowhere uses the parameter. Seem okay?
rahul-tuli
previously approved these changes
Aug 27, 2022
KSGulin
reviewed
Sep 9, 2022
corey-nm
requested review from
KSGulin and
rahul-tuli
and removed request for
kylesayrs
KSGulin
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR is a refactor of the
sparsezoo/utils/authentication.pymodule, as discussed in a previous PR. It also adds unit tests for all the functionality.Summary:
_maybe_load_tokenwhich tries to read in token from a path_save_tokenwhich saves a token to a path