Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhere to dashboard card plattform/user selections for newly implemented cards #351

Open
M4GNV5 opened this issue Oct 27, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers hackathon Will be solved during the next neuland.app Hackathon

Comments

@M4GNV5
Copy link
Member

M4GNV5 commented Oct 27, 2023

Describe the bug
Dashboard entrys that are newly added to the code are displayed to all users even if PLATFORM_X is not set to the current plattform.

To Reproduce

  • open an incognito/private window
  • on desktop: click ctrl+shift+m
  • customize your dashboard (e.g. removing one item)
  • edit your localStorage.personalizedDashboardHidden removing the roomplan entry

You are now at the state of an existing app user just after the roomplan dashboard entry was implemented. Reloading the page the roomplan entry will appear, even though it is only labeled as PLATFORM_DESKTOP and not PLATFORM_MOBILE

Expected behavior
The roomplan should not appear, as it is a desktop only card. When a new dashboard entry is implemented it should only appear on corresponding plattforms.

Screenshots
image

Additional context

@M4GNV5 M4GNV5 added bug Something isn't working good first issue Good for newcomers hackathon Will be solved during the next neuland.app Hackathon labels Oct 27, 2023
@mathisvester
Copy link

@M4GNV5 provided a fix for this issue in #428.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hackathon Will be solved during the next neuland.app Hackathon
Projects
None yet
Development

No branches or pull requests

2 participants