From c853740f23a8278497873e7fb0251bf7a163dc0f Mon Sep 17 00:00:00 2001 From: Lukas Neugebauer <25110308+lneugebauer@users.noreply.github.com> Date: Wed, 18 Sep 2024 15:31:10 +0200 Subject: [PATCH 1/2] Fix modulepreload tag --- Classes/AssetIncludesBuilder.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/AssetIncludesBuilder.php b/Classes/AssetIncludesBuilder.php index c9d92f7..528fad0 100644 --- a/Classes/AssetIncludesBuilder.php +++ b/Classes/AssetIncludesBuilder.php @@ -155,7 +155,7 @@ private function recurseImportedChunkFiles(array &$includes, array $manifestJson foreach ($imports as $import) { $manifestEntry = $manifestJson[$import]; if (isset($manifestEntry['file'])) { - $includes[] = ''; + $includes[] = ''; } if (isset($manifestEntry['imports'])) { $this->recurseImportedChunkFiles($includes, $manifestJson, $manifestEntry['imports']); From 1cf70503e13f6f266d6e66b031c2406a0762f273 Mon Sep 17 00:00:00 2001 From: Lukas Neugebauer <25110308+lneugebauer@users.noreply.github.com> Date: Wed, 18 Sep 2024 19:43:39 +0200 Subject: [PATCH 2/2] Update tests --- Tests/Functional/AssetIncludesBuilderFunctionalTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Tests/Functional/AssetIncludesBuilderFunctionalTest.php b/Tests/Functional/AssetIncludesBuilderFunctionalTest.php index ab0ca35..bdc10d5 100644 --- a/Tests/Functional/AssetIncludesBuilderFunctionalTest.php +++ b/Tests/Functional/AssetIncludesBuilderFunctionalTest.php @@ -49,7 +49,7 @@ public function productionIncludes() '' . PHP_EOL . '' . PHP_EOL . '' . PHP_EOL . - '' + '' , $html, 'should create correct includes for main entry'); $file = $builder->productionUrl('main.js'); @@ -59,7 +59,7 @@ public function productionIncludes() $this->assertEquals( '' . PHP_EOL . '' . PHP_EOL . - '' + '' , $html, 'should create correct includes for other entries'); $file = $builder->productionUrl('views/foo.js');