Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRKey timestamps #29

Closed
aaronbojarski opened this issue Nov 11, 2023 · 3 comments
Closed

DRKey timestamps #29

aaronbojarski opened this issue Nov 11, 2023 · 3 comments

Comments

@aaronbojarski
Copy link
Collaborator

DRKey timestamps for the validity period use unix time in nanoseconds.
This will overflow the uint64_t on Thu Jun 15 2028.

Is nanosecond precision here really needed? If not we could just switch to milliseconds.

@fstreun
Copy link
Collaborator

fstreun commented Nov 12, 2023

In the new SPAO version, we have addressed this concern (and many others), and changed it.
Im particular, see in particular this PR here:
scionproto/scion#4300

I think, we should move to the new version of the SPAO header.

@aaronbojarski
Copy link
Collaborator Author

Ah okay good to know.
That is anyways on the TODO list.

@fstreun
Copy link
Collaborator

fstreun commented Nov 13, 2023

I created a new issue (#30) for adapting the new SPAO header format.

@fstreun fstreun closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants