Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to remove network config from cloud-init #891

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

QcFe
Copy link
Collaborator

@QcFe QcFe commented Mar 19, 2024

Description

This PR removes the injection of the network part into cloud-init (that also complains that should be there...).
Mostly for desperate testing purposes rn.

@QcFe QcFe requested a review from a team as a code owner March 19, 2024 16:46
@kingmakerbot
Copy link
Collaborator

Hi @QcFe. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@QcFe
Copy link
Collaborator Author

QcFe commented Mar 19, 2024

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-891 label to your tenant.

@QcFe QcFe marked this pull request as draft March 26, 2024 15:18
@QcFe
Copy link
Collaborator Author

QcFe commented Sep 6, 2024

/undeploy-staging

@netgroup-polito netgroup-polito deleted a comment from kingmakerbot Sep 18, 2024
@netgroup-polito netgroup-polito deleted a comment from kingmakerbot Sep 18, 2024
@netgroup-polito netgroup-polito deleted a comment from kingmakerbot Sep 18, 2024
@netgroup-polito netgroup-polito deleted a comment from kingmakerbot Sep 18, 2024
@netgroup-polito netgroup-polito deleted a comment from kingmakerbot Sep 18, 2024
@netgroup-polito netgroup-polito deleted a comment from kingmakerbot Sep 18, 2024
@QcFe
Copy link
Collaborator Author

QcFe commented Sep 18, 2024

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-891 label to your tenant.

@QcFe
Copy link
Collaborator Author

QcFe commented Sep 18, 2024

/undeploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants