Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better title of VM noVNC tab #316

Open
GabriFila opened this issue Oct 10, 2020 · 2 comments
Open

Better title of VM noVNC tab #316

GabriFila opened this issue Oct 10, 2020 · 2 comments
Labels
good first issue Good for newcomers kind/feature New feature or request sig/user-environment

Comments

@GabriFila
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When a user has multiple VMs open in the same browser it is hard knowing the tab corresponding to a particular VM.

Describe the solution you'd like
It could be useful to provide in the title of the noVNC tab the id of the VM and after its description.

Additional context
I have no idea if this is possible or where to configure it, but I think it could be useful

@giorio94
Copy link
Member

giorio94 commented Oct 12, 2020

IMO, there may be two alternatives to solve this issue:

  1. Adopt an approach similar to the one used here to add the base tag. Essentially, an additional configuration is added to every ingress resource (through the operator) to modify the content of the title tag and set a custom name. In this case, we could configure whatever title we like.
  2. Directly assign a custom hostname to every VM (or use the default, equal to the VM name), which is then reflected in the title of the noVNC tab and in the terminal prompt. This solution had been disabled quite a long time ago since IIRC the name of the VM was different from the one of the labinstance. This feature could be reintroduced changing the content of this line. Beware it would require to regenerate the VM images.

This image shows what would be outcome of solution 2, with the current VM names (tested using a VM image with the old configuration):
screen

@GabriFila
Copy link
Contributor Author

Regarding the name I just would like to specify a note on UX. I believe the labCode should be first, at least in the HTML title tag of the tab. for these reasons:

  • being at the start of the string it doesn't get hidden when the browser tab shrinks
  • is more probable that a user has multiple active VMs of the same template, so the distinct element is the code

Regarding instead the actual hostname of the VM, it would be great to have it different. Also considering that from now on is possible to ssh into another machine, having all of them with netlab is a bit of a nightmare

@GabriFila GabriFila added the good first issue Good for newcomers label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/feature New feature or request sig/user-environment
Projects
None yet
Development

No branches or pull requests

2 participants