Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fmc_policy_assignment resource and data source #91

Open
danischm opened this issue Jul 16, 2024 · 2 comments · May be fixed by #159
Open

Add fmc_policy_assignment resource and data source #91

danischm opened this issue Jul 16, 2024 · 2 comments · May be fixed by #159
Assignees
@wras66
Labels
enhancement New feature or request
Milestone
Existing Provider...

Comments

@danischm
Copy link
Member

API: /api/fmc_config/v1/domain/{domainUUID}/assignment/policyassignments
@danischm danischm added the enhancement New feature or request label Jul 16, 2024
@danischm danischm changed the title Add fmc_policy_assignment resource Add fmc_policy_assignment resource and data source Jul 16, 2024
@jabielecki jabielecki self-assigned this Jul 17, 2024
@jabielecki
Copy link
Collaborator

jabielecki commented Aug 30, 2024 •
edited
Loading

@danischm Maybe change the title here? Instead of exposing policyassignments it seems more coherent to follow this pattern. (Even if the same code is needed for fmc_device_cluster.)

So something like:

  • Add prefilter_policy_id attribute to fmc_device resource and data source.
  • Add platform_settings_policy_id attribute to fmc_device resource and data source.
  • ...

@jabielecki jabielecki removed their assignment Aug 30, 2024
@wras66 wras66 self-assigned this Oct 18, 2024
wras66 pushed a commit to wras66/terraform-provider-fmc that referenced this issue Oct 25, 2024
@wojciech-bainhelixpe
Add policy assignment resource and data source (netascode#91)
1cd5233
@wras66 wras66 linked a pull request Oct 28, 2024 that will close this issue
Open
@mmaciejc
Copy link
Contributor

mmaciejc commented Oct 28, 2024 •
edited
Loading

as per jabielecki comment:
Add access_policy_id attribute to fmc_device resource and data source. - required (done)
Add prefilter_policy_id attribute to fmc_device resource and data source. - optional
Add platform_settings_policy_id attribute to fmc_device resource and data source. - optional
Add nat_policy_id attribute to fmc_device resource and data source. - optional
Add flex_config_policy_id attribute to fmc_device resource and data source. - optional
Add ra_vpn_policy_id attribute to fmc_device resource and data source. - optional

wras66 pushed a commit to wras66/terraform-provider-fmc that referenced this issue Oct 30, 2024
@wojciech-bainhelixpe
Add policy assignment resource and data source (netascode#91) applyin…
20c463d 
…g change requests
wras66 pushed a commit to wras66/terraform-provider-fmc that referenced this issue Nov 8, 2024
@wojciech-bainhelixpe
Add policy assignment resource and data source (netascode#91) applyin…
9c70dfb 
…g change requests
wras66 pushed a commit to wras66/terraform-provider-fmc that referenced this issue Nov 27, 2024
@wojciech-bainhelixpe
Add policy assignment resource and data source (netascode#91) fix import
0ebd25b
wras66 pushed a commit to wras66/terraform-provider-fmc that referenced this issue Dec 3, 2024
@wojciech-bainhelixpe
Add policy assignment resource and data source (netascode#91) applyin…
106ba25 
…g review suggestions
wras66 pushed a commit to wras66/terraform-provider-fmc that referenced this issue Dec 3, 2024
@wojciech-bainhelixpe
Add policy assignment resource and data source (netascode#91) applyin…
5ca48bc 
…g review suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wras66 wras66

Labels
enhancement New feature or request
Projects
None yet
Milestone
Existing Provider Feature Parity
Development

Successfully merging a pull request may close this issue.

Add policy assignment resource and data source (#91) wras66/terraform-provider-fmc
4 participants
@wras66 @jabielecki @danischm @mmaciejc