Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client does not use proxy settings while connecting to catalyst center #11

Open
becelot opened this issue Oct 22, 2024 · 0 comments · May be fixed by #12
Open

Client does not use proxy settings while connecting to catalyst center #11

becelot opened this issue Oct 22, 2024 · 0 comments · May be fixed by #12

Comments

@becelot
Copy link

becelot commented Oct 22, 2024

Currently, the client does ignore http proxy settings and times out, since I cannot reach catalyst center without the http proxy. Other tools and go client libraries work as expected, and are using the provided http proxy.

Reproduce

Set HTTP_PROXY and HTTPS_PROXY environment variable and use this library.

Expected behaviour

The client uses the proxy and fetches a response from CatalystCenter.

Actual behaviour

The client times out.

Further information

The problem is with the way that the InsecureSkipVerify flag is set. It accidentally overwrites the other default options available in tls.Transport (one of which is the Proxy setting, overwriting the default proxy setting inferred by go).

I tried the fix in my PR, and it works fine afterwards. I also recompiled the catalystcenter terraform provider with this fix (as it relies on this library), and terraform is also working fine afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant