Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve .pre-commit-config by switching to external repos and consolidating #193

Open
HarrisonWilde opened this issue Dec 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@HarrisonWilde
Copy link

In general, it is better practice to minimise project dependencies and instead refer to "external" repos in .pre-commit-config e.g.:

repos:
  - repo: local
    hooks:
      - id: check-added-large-files
        name: Check for added large files
        entry: check-added-large-files
        language: system

Should be:

repos:
  - repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.6.0
    hooks:
      - id: check-added-large-files

We can then automate a workflow to keep these hooks up to date, something like https://gitlab.com/vojko.pribudic.foss/pre-commit-update/ or https://github.com/floatingpurr/sync_with_poetry if we end up on poetry.

@HarrisonWilde HarrisonWilde added the enhancement New feature or request label Dec 18, 2024
@HarrisonWilde
Copy link
Author

As it came up in #197 just flagging this @sqr00t I am going to raise a PR around this and perhaps we can then work together to get the msg out / propagate to cookie cutter projects org wide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant