Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG in code for avg MSOA garden size #84

Open
crispy-wonton opened this issue Nov 19, 2024 · 0 comments · May be fixed by #85
Open

BUG in code for avg MSOA garden size #84

crispy-wonton opened this issue Nov 19, 2024 · 0 comments · May be fixed by #85
Labels
bug Something isn't working

Comments

@crispy-wonton
Copy link
Collaborator

crispy-wonton commented Nov 19, 2024 •
edited
Loading

MSOA avg garden size is joined to the EPC data using MSOA code AND house type, which are defined in lines 19-33 in the generate_df_garden_space_avg function in pipeline/prepare_features/garden_space_avg.py.
Bug: rows with unknown house type are set to have a house type label of the literal string "property_type". This gets joined to nothing and needs to be updated to "unknown" instead.
@crispy-wonton crispy-wonton added the bug Something isn't working label Nov 19, 2024
@crispy-wonton crispy-wonton linked a pull request Nov 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUGFIX avg garden size nestauk/asf_heat_pump_suitability
1 participant
@crispy-wonton