Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make config and paths work for MCS #17

Open
ch-williamson opened this issue May 24, 2022 · 0 comments
Open

Make config and paths work for MCS #17

ch-williamson opened this issue May 24, 2022 · 0 comments
Assignees

Comments

@ch-williamson
Copy link
Contributor

Relevant comments from code review:

  • config

we'll have to transfer all the config information into base_config.py since packages don't include any data files

from config import base_config
BUCKET_NAME = base_config.BUCKET_NAME
INSTALLATIONS_RAW_S3_PATH = base_config.INSTALLATIONS_RAW_S3_PATH
  • paths

we'll have to go through and adjust all data paths so they have the same format throughout. I recommend having a data path that would lead to the ASF core data in a local dir or directly to the S3 bucket, and then a relative path that leads to the specific file. That way we can easily pick whether we want to load it from S3 or local dir, and give the relative path as default values using the config file.

also, EPC in joining script:

        epcs = asf_core_data.getters.epc.epc_data.load_preprocessed_epc_data(data_path='S3', 
            version=epc_version,
            usecols=[relevant features you need for this, defined in base_config.py],
  • refresh - consider how this should work across the package
@ch-williamson ch-williamson self-assigned this May 24, 2022
athrado pushed a commit that referenced this issue Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant