-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run npm model on adult intake #99
Draft
maxhrhadley
wants to merge
16
commits into
dev
Choose a base branch
from
98_update_input
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE 31/10/2024 AUTHOR cmbrennan002
I've updated the files to tidy up work done previously and added a README. Changes made since the first round of work include
To complete this review, please:
Investigations still required are:
- I wonder if this is because the coefficients haven't been updated yet?
Then general sense checks and analysis of how the SWA by store and market change - I've begun this in <ahl_targets/analysis/change_checks_Oct24/new_swa_analysis.py>
Description
Edit:
Please see
pipeline/model_data_diets.py
for the script to generate the input data inline with diets specs.Hey both, @cmbrennan002 I know you've already had a look but just creating this so you can also have a scan @izzyStewart.
All changes to review are in the file
ahl_targets/pipeline/simulation_npm_v2.py
. The big question is why the updated baseline is so much smaller than in diets. Let me know if you have any thoughts on why that's the case!Fixes #98