Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong unit of q_stc in gif_psc_exp #3287

Open
schmitfe opened this issue Aug 8, 2024 · 2 comments
Open

Wrong unit of q_stc in gif_psc_exp #3287

schmitfe opened this issue Aug 8, 2024 · 2 comments
Labels
good first issue Good for newcomers I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.

Comments

@schmitfe
Copy link
Contributor

schmitfe commented Aug 8, 2024

The description of the neuron model gif_psc_exp states that the adaptive current q_stc is given as a list of nA. I think this has to be pA.
I can not find a conversion between nA and pA in models/gif_psc_exp.cpp or models/gif_psc_exp.h, but the sum of all adaptive currents gets added to the parameter I_e which is given in pA.

nest-simulator/models/gif_psc_exp.cpp

Line 357 in 6bed7e3

S_.V_ = V_.P30_ * ( S_.I_stim_ + P_.I_e_ - S_.stc_ ) + V_.P33_ * S_.V_ + V_.P31_ * P_.E_L_

S_.V_ = V_.P30_ * ( S_.I_stim_ + P_.I_e_ - S_.stc_ ) + V_.P33_ * S_.V_ + V_.P31_ * P_.E_L_
+ S_.I_syn_ex_ * V_.P21ex_ + S_.I_syn_in_ * V_.P21in_;
@gtrensch gtrensch added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Aug 9, 2024
@gtrensch gtrensch added this to Models Aug 9, 2024
@github-project-automation github-project-automation bot moved this to To do in Models Aug 9, 2024
@heplesser heplesser added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) good first issue Good for newcomers labels Sep 9, 2024
@PrabhuUdurg
Copy link
Contributor

Hey, I would like to work on this issue)

@github-actions GitHub Actions
Copy link

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Models
Status: To do
Milestone
No milestone
Development

No branches or pull requests
4 participants
@heplesser @schmitfe @gtrensch @PrabhuUdurg