Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Linux section of CI build matrix #2771

Open
heplesser opened this issue May 8, 2023 · 1 comment
Open

Review Linux section of CI build matrix #2771

heplesser opened this issue May 8, 2023 · 1 comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.

Comments

@heplesser
Copy link
Contributor

While working on #2762, I noticed some points in the CI build matrix for Linux, which may deserve attention:

We first set

env:
CXX_FLAGS: "-pedantic -Wextra -Woverloaded-virtual -Wno-unknown-pragmas"
NEST_VPATH: "build"
NEST_RESULT: "result"

and then later change this to

export CXX_FLAGS="-pedantic -Wextra -Wno-unknown-pragmas -D_GLIBCXX_ASSERTIONS"

Shouldn't we set it in one place only?

Also, why do we have

if [ "$xNEST_BUILD_COMPILER" = "CLANG" ]; then
export CC=clang-11
export CXX=clang++-11

where is NEST_BUILD_COMPILER set and why are we binding ourselves to clang-11, while the most recent version is 16.0?

Finally and unrelated, what is the purpose of this commented-out section (exists similarly for macOS):

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels May 8, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Development

No branches or pull requests

1 participant