Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: let old config node open ws listen by default #4741

Merged
merged 1 commit into from
Dec 5, 2024
Merged

feat: let old config node open ws listen by default #4741

merged 1 commit into from
Dec 5, 2024

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Dec 5, 2024

What problem does this PR solve?

Added reuse_tcp_with_ws option, the default value is true, so that all nodes upgraded to this version will enable the TCP + WS listening mode by default

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo requested a review from a team as a code owner December 5, 2024 07:37
@driftluo driftluo requested review from zhangsoledad and removed request for a team December 5, 2024 07:37
@driftluo driftluo force-pushed the open-ws-listen-by-default branch from ba6de48 to 8fbad87 Compare December 5, 2024 07:43
eval-exec
eval-exec previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@eval-exec eval-exec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about use a big Braces to encompass L1166 to L1220

#[cfg(not(target_family = "wasm"))]
{ 
   L1166 -> L1220
   ...
   ...
}

@driftluo driftluo force-pushed the open-ws-listen-by-default branch from 8fbad87 to 3f8e075 Compare December 5, 2024 07:50
eval-exec
eval-exec reviewed Dec 5, 2024
View reviewed changes
network/src/network.rs Outdated Show resolved Hide resolved
@driftluo driftluo force-pushed the open-ws-listen-by-default branch from 3f8e075 to 574a86f Compare December 5, 2024 07:55
eval-exec
eval-exec previously approved these changes Dec 5, 2024
View reviewed changes
zhangsoledad
zhangsoledad previously approved these changes Dec 5, 2024
View reviewed changes
@zhangsoledad zhangsoledad added this pull request to the merge queue Dec 5, 2024
@quake quake removed this pull request from the merge queue due to a manual request Dec 5, 2024
@driftluo driftluo dismissed stale reviews from zhangsoledad and eval-exec via 52b5ec1 December 5, 2024 10:41
@driftluo driftluo force-pushed the open-ws-listen-by-default branch 4 times, most recently from 8fca463 to 0917e0f Compare December 5, 2024 11:39
@driftluo driftluo force-pushed the open-ws-listen-by-default branch from 0917e0f to fc8e0d6 Compare December 5, 2024 13:31
@eval-exec eval-exec added b:cli Break cli options and config file m:network labels Dec 5, 2024
@zhangsoledad zhangsoledad added this pull request to the merge queue Dec 5, 2024
Merged via the queue into nervosnetwork:develop with commit 14e769b Dec 5, 2024
32 checks passed
@driftluo driftluo deleted the open-ws-listen-by-default branch December 5, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@eval-exec eval-exec eval-exec left review comments

Assignees
No one assigned
Labels
b:cli Break cli options and config file m:network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driftluo @zhangsoledad @eval-exec