From f4e67c1c6d62b945045ff74192b548f8b493cb56 Mon Sep 17 00:00:00 2001
From: zhangsoledad <787953403@qq.com>
Date: Wed, 16 Oct 2024 02:49:50 +0000
Subject: [PATCH] Merge pull request #4679 from libraries/fix_inherited_fds

fix(script): fixed panic when calling inherited_fds in root process
---
 script/src/scheduler.rs                       |   6 +++++-
 .../tests/ckb_latest/features_since_v2023.rs  |   6 ++++++
 script/testdata/spawn_cases                   | Bin 15664 -> 15728 bytes
 script/testdata/spawn_cases.c                 |  13 +++++++++++++
 4 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/script/src/scheduler.rs b/script/src/scheduler.rs
index 3c93c0ee82..358acda0e5 100644
--- a/script/src/scheduler.rs
+++ b/script/src/scheduler.rs
@@ -462,7 +462,11 @@ where
                     );
                 }
                 Message::InheritedFileDescriptor(vm_id, args) => {
-                    let inherited_fd = self.inherited_fd[&vm_id].clone();
+                    let inherited_fd = if vm_id == ROOT_VM_ID {
+                        Vec::new()
+                    } else {
+                        self.inherited_fd[&vm_id].clone()
+                    };
                     let (_, machine) = self.ensure_get_instantiated(&vm_id)?;
                     let FdArgs {
                         buffer_addr,
diff --git a/script/src/verify/tests/ckb_latest/features_since_v2023.rs b/script/src/verify/tests/ckb_latest/features_since_v2023.rs
index e99dd32f5b..d5eb783ca0 100644
--- a/script/src/verify/tests/ckb_latest/features_since_v2023.rs
+++ b/script/src/verify/tests/ckb_latest/features_since_v2023.rs
@@ -1235,6 +1235,12 @@ fn check_spawn_index_out_of_bound() {
     assert_eq!(result.is_ok(), SCRIPT_VERSION == ScriptVersion::V2);
 }
 
+#[test]
+fn check_root_inherited_fds() {
+    let result = simple_spawn_test("testdata/spawn_cases", &[19]);
+    assert_eq!(result.is_ok(), SCRIPT_VERSION == ScriptVersion::V2);
+}
+
 #[test]
 fn check_spawn_cycles() {
     let script_version = SCRIPT_VERSION;
diff --git a/script/testdata/spawn_cases b/script/testdata/spawn_cases
index dbfddd345ed1167b7eaef2daf6f3c557fb28148e..c4acb37967aa7150eb5afaddb7a3994567c289f3 100755
GIT binary patch
delta 2566
zcmZuze@qis9KSo-qd<|<f>J1@)RrFyLIp*Hrl3ZuM#U|inPx;7HEhdfA=4$gFpyl!
zG|NC=+>gWo5(A4_kXn@>V|9yj=<Hx_f9MkBhJ+wPTQ*q$ncaJLeJ#3O^6mTHd*AQp
zeZD{5yY?LM9cf9Y3`Hl{{M?0HLU`~<FycE22O6ni;ybYk&A?~ViIXO($L72}9!4Ec
za$S*R(&2`LCg7m8U@9`1Gyr+j)z}D~!Y<KzeQs}u14zX;z(;9msZJr4YJp6yro~xT
zmi#pdb*9U8oZ+ZcaoOu@e%e`~wbRzh%EkuI{vG=}917Y%1AD-IjbeUF(DdQmUSu+}
zTS050v5D6gGcjX1B&^KA6<!`%v5n7Jwz~J!da6NFxZd?%Yyqi)Xmm@INV@E2584n0
zu)Y-7?Rs!CE`he|1>%!&34$#n6K%aeV%t4}txL1Kgw#lNh%mN^xh&Yw?G!>oexPB6
z$|NFsedjM6vW&xMORb$&J&M<g%munZO12)nje_14CXo7Vg$k2eSP@T!>%n$y0oWPe
zkcE@q+=f_OrEvkgK3i)DhLH#`^YLm7qgJZb*!TQrTiqfN1?>|Pk9hA@zKyMKDKElJ
zU5yEH5{JUK{WS>#*=CJiRJMk2A!=B4FW)x(y-*Rvt0FiLZY2iuJCzuWYKbZvMP*X8
zsuxv<ufHFPVOOLWgDU8xN*crjCzDKA%~r?nMHqpK@FPEjFdCu|2IO}AT#eQqd2rIY
zBfuW@O^dLKO7G?CuN}6W>Me(T)4{V%EEmf#GSoq!U45W1P))wAzq5k2rrJjj;@(9t
z1Z+%fQQtRbdB^RkURx`z65LI!5gf?e2(Bj^F=3hJ8CK;f!Qiq})}V}7Q`+%jq*klJ
zxb9<zE#+>sTg}pYy`E|%#^0{(HU#R*4=udV6a4w7p<HN|iMg=NgJ<!}LCH!<Bu3Af
z1-y2-wk0gsO}uyJe|yBSlEd^EoffMFx^Apa=~%3)^ctbY`pd@PMjr9#2NJmGFyQLN
z1kap;ZjTo_z>xYZ$h5f+)TG5Hz<Q%Ah`05kh=-M){ldvZ=lQKPHM)pULw}qmr1V<a
zI6SnX!_XNaMTsE?FW=nW!GV_a1RXZYX+=hi>Td5j2fBS=KPTc616fA!Ol4(!g=4*+
zp$d{3`Y4q2k|ZI7ST<cq1^act;bdk)d>|>qBlC5Zy8rgf2d`rT_oL@e-aoJnN>VT*
z@38w11dvqgnCh759HYkU<|_FN;W1Y|>dHs=U{h+O)O1R<p|L5Q@bdmfmXk0j!V*2$
znU!8&qmP&hlaQ2hZ1GKn3>x$({Ln`J(Zv?W%=R}-6O@m7B4gw-vh-*vX+CNOAI^5X
z3%?~XgfHg1>O_f@KuErn@>$O>h&Z8r9@CwCug+503z_*wMp<sajWqvlmOBMgA{?Q?
ztb%38(~$fieCE#$cv`n=eTH=Au~T$yW4Y-8<T^CVayJCc_K@X%zZCcoI98RC^<{l5
z_eH-r!!Y*E<Yp6O@8ySjS+1{N@OH9XhNyM094TmJ4J@a0!ByV<gym-Xkk<AS%X#`F
zjEGf0bUGNBfHy%+p^U(y^t0T9Xz4B7Lc=of3ce<WlP{JFF#fYFcgTqV{SKDf;Y6uH
zhg_o%C4Hasu;qpmB~cSM?If4dQ`(7d%~hja8nk&+CTP!5Q6ry#Z*sD>6c2B-j#fx3
zZG5pmp!sZp6ht}%f;=_m<-KRiKS!n6a0l;L5xZ!|PFJp>kjyQ+8N`^wxMhRL1F_-b
zLLUC+h=DrG`b(gFbxVC`4oM(64do=1-B7ke*$AZoN;VW76giYDt4N{;N+*=lP+o<y
z1d0U8d=^P`L-}<zNnC*P7}}3QnT4V<h<a*ZG{CVCN{xYBCK$CshcBTZhfy$)yALpV
z5}?XcCES6tFFs-Duh1sf%Xu`Z4E`IEh*s~zfgz^-3!rvQ7r6kGYd<Bsfpcw}k}yAy
z6h$G+Fk%6`nQtZsffN2NfVun}_?xjVha$|bz3cuCi%ws?Xn#;^RDhZyW+~=%C$Opm
uCyH_+gKYA^%_0*7iZB*aOY*=rqlqj5$Bf0K58N;oNAQIr=2q~MG5KG__iZcy

delta 2501
zcmZuze@qis9KSo-vlNumg0`iUQmepOC?F_c2S_5wqRuScGL24<8nXoj6E)L?m9cAy
zW>N6PZ1WG>VS;EDg;iw?x7NiUbF%^2A5$0ghJ+!jYuUsAD(=0zzP7qG`S!l|-uL@?
zpYN}`3-0gQ-<m-Mi`&>`dEPui_~9$Ti1#GC&``XTc<(JoEAYO&?MMm5)O8Pz#87gz
z`&-EpdX`b$0vrx4@XJ$4BZ!alCLYi!?3^|b^aR=+Kq}q=K2A^Dbqc9n3uN(HT3mG-
z<2OmD-%q#?G90y7+ztc}Kkca2+i7b}O>>iP+uCjI4h5Y<1AE9lUopKpZ2Ita4>Fl}
zTS4n)W0OEIVRXW>N7$KyJA8a(r+#G0QsvpO%eNi0w4}NBCKi$!h(@=@iKO4S=|cy?
z0E#MrU8)B^C8=qtULZb}q!w%$nP?mM8QX3UY~8x~Wu(roLxizS!Ue&Gc2Nio`GKYd
zni3H)5Ip<!9?J-fw!+$BU4-JbB6ERmm{NTgK1M;Wj}b`SS)jqBo-I&PEooqlz7VWa
zHW_j94?7VHFO3Tj2-Y8uz%UX4W?HGmFj|#Xi+#_2UgZ&qDCi(9kU_jRs_L-y4b?e#
zsJmGmPvTH`=RadGkk_rVqsrDaONbg)J-|E1uLu=EysE?N;6`#dzy9QKRC6@hD5?_8
zacxv}c-y^54D01$44SZ$Cgn#=a4e++tJzxRMuZWn2!H=t1fwYqVL)zIPdDi8^4(+B
zwITMXZ(4<2RQdpKyS&eGv}ZHyn|7XUVYx(xk)aL(F73|ZP&IjHUq>}<U2GrPje8ft
z5U??^g{^nWvcu!sUa(7AE4Y`iX0UTfIk=i?#)M_M8LY;qg@emZ%SRcprn&H@T(8$*
zT+e}hmdze?TEpDCJ-+QKjK4;ICMQ%^zW>=PJ;9%S8p(xjo|udJX)vRl56Tuw<QUyF
z33&Z{eQQj(oA|)Q|MrMuA&2QP20c~_4QH_GH?UaMEYb-zUUb16KFBAIekg%a!+@)o
z5S}>&?NSOIkh6Fu%=B<CXh>J8VZG5Kh_CNK5f7+*+l0wO^Zb6g7CneiLmx^PQhGUk
z1P-m}(Ep{7qU4A}fIsYN=Rj+Q+JKEr$B_}Ex!rTxfu26FpObNkfh;pTQ^w4%aIE(-
zHDOZypGJ~imLi0Z$YuzsU@wLojx13tLrEF9Kiz0){BO^Ev=tk89=$wy&tV&srC~;a
z0neWZAZ3@s-#*$gOby#BYvU(~>y@?q$$a!2oV8FcEjg-L+1!#r1o#)tEGJ=5gbfC;
z&Y1D0%Mk02k&u*XIQmJ247v;`{K!EshN3MXSkU<g%RTHtn&(%Ry97H^==#L0Lc;@M
zViGaUNqrf__FE&Iw2<MuSw)%D#NRsv2-^vkQ+W_r{WF%!71k0Sv0QA(+U?D%AZ>w*
zEVrsp^k*3RDsojxka`Szp^xQi`ULOuEY~J#9V~asjn)F6u-wN;<F`z*TngIdO9xr5
zz%5}!tU{v0!N>%>QOZvt%z-T)mU|$V4&Xi*kb$@GtPgm4uJj@pXD7?u?H06yEH~bZ
z!bOw1-Vl|!bNeh4y(p);B$b<-OZ)Ysmnv(APU_I%*V4fqlZLV#1Cu7>>ifTxTZgKp
zHTA*%W~?RjiX`O@fgn!}!@lj@{6(@vO02wvPpnRiI`NddE~l8x5BS0u&qErIUTkZH
z_b#6l@o<9J?;0&d=LrJb%5AmPnMeZ3Rw(a4(Lk98MFwRin<O4X8G|wir74Rf_Cl$H
zvK5LJ$`3}8_y)=uD93V1;sYq>pl>IX@1YEZbbsjj1YU_8l2`@>+RP!W&|xPO<j@JG
z^0t6YOEqd2TzT~uL&U(37x$5+G^xTLGlWF6`Vd|iV*G^{bmyNWy<kJZXXI`$Uf@)D
zD_%y5gP%hTLIS6jRg#CmIQ;j5qU9#||K4&F<*jfZTmB?w_Fp+s=Ywvu0(7ll=3-v1
yTya+iZmuxNF&l3lkef>&P?foq8q5O+;SB+<n@h<q5c^tbtgBe`sse51)PDhmA%AQD

diff --git a/script/testdata/spawn_cases.c b/script/testdata/spawn_cases.c
index 43c8d96791..171164df03 100644
--- a/script/testdata/spawn_cases.c
+++ b/script/testdata/spawn_cases.c
@@ -536,6 +536,17 @@ int parent_index_out_of_bound(uint64_t* pid) {
     return err;
 }
 
+int parent_root_inherited_fds() {
+    uint64_t fds[2] = {0};
+    uint64_t length = 2;
+    int err = ckb_inherited_fds(fds, &length);
+    CHECK(err);
+    CHECK2(length == 0, -1);
+    err = 0;
+exit:
+    return err;
+}
+
 int parent_entry(int case_id) {
     int err = 0;
     uint64_t pid = 0;
@@ -577,6 +588,8 @@ int parent_entry(int case_id) {
         return parent_invaild_index(&pid);
     } else if (case_id == 18) {
         return parent_index_out_of_bound(&pid);
+    } else if (case_id == 19) {
+        return parent_root_inherited_fds();
     } else {
         CHECK2(false, -2);
     }