Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EXLA to enable use of at least CPU-based ML #559

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lawik
Copy link
Collaborator

@lawik lawik commented Sep 13, 2024

From working with Paulo Valente and Jonatan Klosko it seems we need to run from unreleased versions right now. Not sure what fix it is we need but that was the case when I tried to run Whisper.

@lawik lawik requested a review from fhunleth September 13, 2024 19:42
@lawik
Copy link
Collaborator Author

lawik commented Sep 13, 2024

I think this is all that's needed. I didn't build and run it. If you need me to, I can.

Copy link
Contributor

@fhunleth fhunleth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really amazing. Thanks for getting this started.

@fhunleth
Copy link
Contributor

fhunleth commented Oct 8, 2024

I rebased on main and updated to use hex.pm versions of everything now that they've been released. It seems really close, but still doesn't compile on CI. I'm able to build on MacOS with a manual change to the exla Makefile. That change shouldn't be needed on Linux, so I'm surprised CI didn't work, but will have to look into more later.

@fhunleth fhunleth force-pushed the add-exla branch 2 times, most recently from ff9194a to 152d8f7 Compare October 9, 2024 01:13
@lawik
Copy link
Collaborator Author

lawik commented Oct 9, 2024

Let me know if you need me to try this on anything.

@fhunleth
Copy link
Contributor

fhunleth commented Oct 9, 2024

@lawik Could you check it? I think it works, but it's pretty easy to hang my RPi5 when using Bumblebee, so I'm not sure.

@lawik
Copy link
Collaborator Author

lawik commented Oct 9, 2024

I'll give it a bash :)

@fhunleth
Copy link
Contributor

This PR requires elixir-nx/nx#1543 to build on MacOS and on Linux machines that have CUDA tools installed. There are a couple ways this could be fixed, but that's why I haven't merged it yet.

@fhunleth
Copy link
Contributor

I rebased again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants