Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we try to migrate the legacy back-ported NodeTypeConstraints? #60

Open
mhsdesign opened this issue May 14, 2024 · 2 comments
Open

Comments

@mhsdesign
Copy link
Member

mhsdesign commented May 14, 2024

Neos 8.3 contains findChildNodes as replacement for the deprecated getChildNodes

As seen here:
https://github.com/neos/neos-development-collection/blob/928cc4aa5b427b84cf18ae2af8578e916d0d3afb/Neos.ContentRepository/Classes/Eel/FlowQueryOperations/ChildrenOperation.php#L159

$node->getChildNodes('Neos.Neos:Document')

was replaced at some places with

$node->findChildNodes($this->nodeTypeConstraintFactory->parseFilterString('Neos.Neos:Document'))

im not sure if consumers really adapted to that but i have seen it around ^^

before we migrate anything here we should probably first migrate getChildNodes('Neos.Neos:Document') instead of the "newer" findChildNodes.

Fun really starts to begin with using complex filters with negation and comma: Neos.Neos:ContentCollection,Neos.Neos:Content,!Vendor.Site:Exclude

Additionally $limit = null and $offset = null might need to migrated as well if we find it worth. But the api changed see FindChildNodesFilter.

@dlubitz
Copy link
Contributor

dlubitz commented Nov 21, 2024

@mhsdesign Any news here?

@mhsdesign mhsdesign changed the title Wip task migrate NodeTypeConstraints Should we try to migrate the legacy back-ported NodeTypeConstraints? Dec 9, 2024
@mhsdesign
Copy link
Member Author

Okay updated the description. And also stated that its probably more worth to migrate getChildNodes('Neos.Neos:Document') than the backported - now removed - NodeTypeConstraintFactory ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants