NodeSearchService removed

[pKallert]

In neos/neos-development-collection#4555 (comment) we removed the NodeSearchService. There was also a discussion about re-adding the Service, but was decided against: neos/neos-development-collection#3771

There are Upgrade instructions in the PR to migrate, but we should think about adding a comment or hint directly using rector.

[dlubitz]

- $nodes = $this->nodeSearchService->findByProperties(string $term, array $searchNodeTypes);
+ $nodes = $this->subgraph->findDescendantNodes(
+     $entryNode->nodeAggregateId,
+     FindDescendantNodesFilter::create(
+         nodeTypes: NodeTypeConstraints::create(
+             NodeTypeNames::fromStringArray($searchNodeTypes),
+             NodeTypeNames::createEmpty()
+         ),
+         searchTerm: $term,
+     )
+ );

[dlubitz]

We also need to check for the interface: Neos\Neos\Domain\Service\NodeSearchServiceInterface