From 759ebd832e51909c2766a6bd209342306c002d78 Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Mon, 30 Oct 2023 15:06:03 +0100 Subject: [PATCH] BUGFIX: Apply multiple properties from inspector --- Classes/Domain/Model/Feedback/Operations/UpdateNodeInfo.php | 2 +- Classes/Domain/Model/FeedbackCollection.php | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Classes/Domain/Model/Feedback/Operations/UpdateNodeInfo.php b/Classes/Domain/Model/Feedback/Operations/UpdateNodeInfo.php index a5093bac59..a7ee6a8eed 100644 --- a/Classes/Domain/Model/Feedback/Operations/UpdateNodeInfo.php +++ b/Classes/Domain/Model/Feedback/Operations/UpdateNodeInfo.php @@ -113,7 +113,7 @@ public function serializePayload(ControllerContext $controllerContext): array * * @return array> */ - public function serializeNodeRecursively(Node $node, ControllerContext $controllerContext): array + private function serializeNodeRecursively(Node $node, ControllerContext $controllerContext): array { $contentRepository = $this->contentRepositoryRegistry->get($node->subgraphIdentity->contentRepositoryId); $nodeAddressFactory = NodeAddressFactory::create($contentRepository); diff --git a/Classes/Domain/Model/FeedbackCollection.php b/Classes/Domain/Model/FeedbackCollection.php index 0857f1adbe..5f5a9dd9f7 100644 --- a/Classes/Domain/Model/FeedbackCollection.php +++ b/Classes/Domain/Model/FeedbackCollection.php @@ -48,8 +48,9 @@ public function setControllerContext(ControllerContext $controllerContext) */ public function add(FeedbackInterface $feedback) { - foreach ($this->feedbacks as $value) { - if ($value->isSimilarTo($feedback)) { + foreach ($this->feedbacks as $i => $value) { + if ($feedback->isSimilarTo($value)) { + $this->feedbacks[$i] = $feedback; return; } }