BUG: Replacing an image with an SVG leads to "division by zero"

[dlubitz]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

If yor try to replace an image in the media module, that already contains variants, with an other image, the AssetService tries to refit the new image.

In case the new image is an SVG no height or wight is provided to calculate the aspect ratio nor new dimensions. This leads to a "division by zero" error in the adjustment:

neos-development-collection/Neos.Media/Classes/Domain/Model/Adjustment/CropImageAdjustment.php

Lines 274 to 289 in 6011f88

	public function refit(ImageInterface $image): void
	{
	$this->x = 0;
	$this->y = 0;
	$ratio = $this->getWidth() / $image->getWidth();
	$this->setWidth($image->getWidth());
	$roundedHeight = (int)round($this->getHeight() / $ratio, 0);
	$this->setHeight($roundedHeight);
	if ($this->getHeight() > $image->getHeight()) {
	$ratio = $this->getHeight() / $image->getHeight();
	$roundedWidth = (int)round($this->getWidth() / $ratio, 0);
	$this->setWidth($roundedWidth);
	$this->setHeight($image->getHeight());
	}

Expected Behavior

No refit if a replacement with a SVG is processed.

Steps To Reproduce

• add image to media library
• ensure variants are created (resize/crop)
• replace this image with an SVG

Environment

- Flow: 7.3
- Neos: 7.3
- PHP: 8.1

Anything else?

No response