Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Check and fix Neos:NodeTypes packages #4705

Closed
12 tasks done
ahaeslich opened this issue Nov 5, 2023 · 3 comments · Fixed by #4706
Closed
12 tasks done

TASK: Check and fix Neos:NodeTypes packages #4705

ahaeslich opened this issue Nov 5, 2023 · 3 comments · Fixed by #4706
Assignees
@ahaeslich
Labels
9.0

Comments

@ahaeslich
Copy link
Member

ahaeslich commented Nov 5, 2023 •
edited
Loading

Packages:
@ahaeslich ahaeslich self-assigned this Nov 5, 2023
@ahaeslich ahaeslich moved this to In Progress 🚧 in Neos 9.0 Release Board Nov 5, 2023
ahaeslich added a commit to ahaeslich/neos-development-collection that referenced this issue Nov 6, 2023
@ahaeslich
BUGFIX: Neos.NodeTypes.AssetList:AssetList prototype is now a Content…
6daf500 
…Component

The NodeType fusion renderer is now pure fusion, the behavior including attributes is kept.

Relates: neos#4537
Relates: neos#4705
ahaeslich added a commit to ahaeslich/neos-development-collection that referenced this issue Nov 6, 2023
@ahaeslich
BUGFIX: Neos.NodeTypes.ContentReferences:ContentReferences prototype …
0b015eb 
…is now a ContentComponent

The NodeType fusion renderer is now pure fusion, the behavior including attributes is kept.

Relates: neos#4537
Relates: neos#4705
ahaeslich added a commit to ahaeslich/neos-development-collection that referenced this issue Nov 6, 2023
@ahaeslich
BUGFIX: Neos.NodeTypes.ColumnLayouts prototypes are now a ContentComp…
1df9730 
…onent

The NodeType fusion renderer is now pure fusion, the behavior including attributes is kept.

Relates: neos#4537
Relates: neos#4705
ahaeslich added a commit to ahaeslich/neos-development-collection that referenced this issue Nov 6, 2023
@ahaeslich
BUGFIX: Neos.NodeTypes.ColumnLayouts prototypes are now ContentCompon…
69ef8d4 
…ents

The NodeType fusion renderer is now pure fusion, the behavior including attributes is kept.

Relates: neos#4537
Relates: neos#4705
ahaeslich added a commit to ahaeslich/neos-development-collection that referenced this issue Nov 6, 2023
@ahaeslich
BUGFIX: Neos.NodeTypes:Headline prototype is now a ContentComponent
a9a608b 
The NodeType fusion renderer is now pure fusion, the behavior including attributes is kept.

Relates: neos#4537
Relates: neos#4705
ahaeslich added a commit to ahaeslich/neos-development-collection that referenced this issue Nov 6, 2023
@ahaeslich
BUGFIX: Neos.NodeTypes:Text prototype is now a ContentComponent
562d152 
The NodeType fusion renderer is now pure fusion, the behavior including attributes is kept.

Relates: neos#4537
Relates: neos#4705
@ahaeslich ahaeslich linked a pull request Nov 6, 2023 that will close this issue
BUGFIX: Neos.NodeTypes prototypes are now ContentComponents #4706
Merged
6 tasks
@ahaeslich
Copy link
Member Author

@mficzel looking into this I have found that Neos.NodeTypes.Form:Form uses the fluid based form implementation instead of Neos.Fusion.Form. Should we migrate this NodeType to use the new package?

@ahaeslich
Copy link
Member Author

Besides cleaning up those prototypes: Should we also cleanup the migrations in https://github.com/neos/neos-development-collection/tree/9.0/Neos.NodeTypes/Migrations as we have done for other packages in Neos 9.

Maybe @kdambekalns , @Sebobo and @mficzel have an idea about this.

@mficzel
Copy link
Member

mficzel commented Nov 6, 2023

@ahaeslich i see not much hope for Neos.NodeTypes.Form:Form and no point in updating it. We should define new "default" nodetypes (without rendering) in future once we have a working concept of nested properties in the inspector.

@ahaeslich ahaeslich removed the 9.0beta1 label Nov 7, 2023
ahaeslich added a commit to neos/Neos.Demo that referenced this issue Nov 8, 2023
@ahaeslich
TASK: Update dependencies to require Neos 9 compatible versions of ne…
ec04f81 
…os/nodetypes*

Relates: neos/neos-development-collection#4705
@ahaeslich ahaeslich mentioned this issue Nov 8, 2023
Merged
ahaeslich added a commit to ahaeslich/neos-development-collection that referenced this issue Nov 9, 2023
@ahaeslich
BUGFIX: Neos.NodeTypes.Form:Form prototype is now a ContentComponent
2c8ac2e 
Use `Neos.Fusion:Template` to render only the fluid form via old template file.

Relates: neos#4537
Relates: neos#4705
@ahaeslich ahaeslich moved this from In Progress 🚧 to Under Review 👀 in Neos 9.0 Release Board Nov 10, 2023
@github-project-automation github-project-automation bot moved this from Under Review 👀 to Done ✅ in Neos 9.0 Release Board Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahaeslich ahaeslich

Labels
9.0
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUGFIX: Neos.NodeTypes prototypes are now ContentComponents ahaeslich/neos-development-collection
2 participants
@mficzel @ahaeslich