Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to WorkspaceName instead of ContentStreamId in commands #4694

Closed
bwaidelich opened this issue Nov 3, 2023 · 0 comments · Fixed by #4708
Closed

Refer to WorkspaceName instead of ContentStreamId in commands #4694

bwaidelich opened this issue Nov 3, 2023 · 0 comments · Fixed by #4708
Labels

Comments

@bwaidelich
Copy link
Member

Currently, most commands (all implementing the RebasableToOtherContentStreamsInterface) refer to the content stream id.
This has several issues:

  • Content Stream are mostly an implementation detail. The intention is to commit changes to a workspace
  • As a result, the common use case is cumbersome right now (fetch workspace via WorkspaceFinder to determine content stream id, ...)
  • When we introduce "command interception" for privilege enforcement (see WIP: FEATURE: Content Repository Privileges #4185 (comment)) it will be harder to determine the allowed content streams for the authenticated user
  • To re-apply commands during rebasing, we need to change the CS id currently (createCopyForContentStream()) – by referring to the workspace, we should be able to simply copy the commands
  • Lastly, by referring to the workspace, we will be able to implement some retry mechanism when aggregate checks fail due to a changed content stream during publish/rebase (see Potential race condition when publishing nodes leading to lost content #4680 for example)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants