Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Tethered site children without uriPathSegment can never get one #4608

Closed
1 task done
nezaniel opened this issue Oct 13, 2023 · 0 comments · Fixed by #4617
Closed
1 task done

BUG: Tethered site children without uriPathSegment can never get one #4608

nezaniel opened this issue Oct 13, 2023 · 0 comments · Fixed by #4617
Assignees
Labels

Comments

@nezaniel
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When tethered child documents are added to a site node without a default value for uriPathSegment, they will not get their own URI

Expected Behavior

uriPathSegments that are added later should also take effect

Steps To Reproduce

  • add a tethered document to your site node type without default uriPathSegment
  • run a creation command or structureAdjustments:fix
    -> the tethered child will show up instead of the homepage on path '/'

Environment

- Flow: 9.0-dev
- Neos: 9.0-dev
- PHP: 8.0

Anything else?

This happens because in DocumentUriPathProjection::550 and following:

$oldUriPath = $node->getUriPath();
// homepage -> TODO hacky?
if ($oldUriPath === '') {
  continue;
}

Instead of checking for empty string, we should check against the site node type introduced in #4563

@nezaniel nezaniel added the 9.0 label Oct 13, 2023
@nezaniel nezaniel self-assigned this Oct 13, 2023
@mhsdesign mhsdesign moved this from Todo to Under Review 👀 in Neos 9.0 Release Board Oct 16, 2023
@mhsdesign mhsdesign moved this from Under Review 👀 to In Progress 🚧 in Neos 9.0 Release Board Oct 18, 2023
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✅ in Neos 9.0 Release Board Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant