Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename (and overhaul?) NodeHiddenStateProjection #4315

Closed
bwaidelich opened this issue Jun 7, 2023 · 4 comments
Closed

Rename (and overhaul?) NodeHiddenStateProjection #4315

bwaidelich opened this issue Jun 7, 2023 · 4 comments
Assignees

Comments

@bwaidelich
Copy link
Member

As @mhsdesign correctly brought up, the term NodeHiddenState is not in sync with the notion of disabled nodes.

I guess, with the suggestions from #3732 we could that projection into one that calculates "attributes" (or what we end up calling these) for nodes and their descendants, such that instead of

$nodeHiddenStateFinder->findHiddenState();

we could do something like

$nodeAttributeResolver->hasAttribute(NodeAddress $node, 'disabled');
@mhsdesign
Copy link
Member

@nezaniel and me discussed to rename the NodeHiddenState directly to NodeRestrictionState so we can later with Neos 9.1 enrich this feature with more than just two states (frontend users and backend users): #3732

@skurfuerst skurfuerst moved this from Todo to Prioritized 🔥 in Neos 9.0 Release Board Sep 1, 2023
@skurfuerst skurfuerst self-assigned this Sep 1, 2023
@mhsdesign
Copy link
Member

We want to move this projection into Neos.Neos to make this less "stable api"

@mhsdesign mhsdesign moved this from Prioritized 🔥 to In Progress 🚧 in Neos 9.0 Release Board Sep 24, 2023
@mhsdesign
Copy link
Member

might be solved with the introduction of attributes: #4550

@mhsdesign mhsdesign moved this from In Progress 🚧 to Todo in Neos 9.0 Release Board Sep 26, 2023
@mhsdesign mhsdesign moved this from Todo to In Progress 🚧 in Neos 9.0 Release Board Sep 26, 2023
@mhsdesign
Copy link
Member

Solved via #4550

$nodeIsDisabled = $node->tags->contain(SubtreeTag::disabled());

@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✅ in Neos 9.0 Release Board Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants