diff --git a/Neos.Fusion/Classes/Service/HtmlAugmenter.php b/Neos.Fusion/Classes/Service/HtmlAugmenter.php index bb9c49ec56d..c1139d0cf2c 100644 --- a/Neos.Fusion/Classes/Service/HtmlAugmenter.php +++ b/Neos.Fusion/Classes/Service/HtmlAugmenter.php @@ -59,11 +59,11 @@ public function addAttributes($html, array $attributes, $fallbackTagName = 'div' * Detects a unique root tag in the given $html string and returns its DOMNode representation - or NULL if no unique root element could be found * * @param string $html - * @return \DOMNode + * @return \DOMNode|null */ protected function getHtmlRootElement($html) { - $html = trim($html); + $html = trim((string)$html); if ($html === '') { return null; } diff --git a/Neos.Media/Classes/Domain/Model/Image.php b/Neos.Media/Classes/Domain/Model/Image.php index 6c6eabb5adf..b8819c3d0d6 100644 --- a/Neos.Media/Classes/Domain/Model/Image.php +++ b/Neos.Media/Classes/Domain/Model/Image.php @@ -176,4 +176,19 @@ protected function calculateDimensionsFromResource(PersistentResource $resource) $this->width = is_int($imageSize['width']) ? $imageSize['width'] : null; $this->height = is_int($imageSize['height']) ? $imageSize['height'] : null; } + + /** + * Set the asset collections that include this asset and + * keeps the attached variants' collections in sync. + * + * @param Collection $assetCollections + * @return void + */ + public function setAssetCollections(Collection $assetCollections) + { + parent::setAssetCollections($assetCollections); + foreach ($this->variants as $variant) { + $variant->setAssetCollections($assetCollections); + } + } } diff --git a/Neos.Media/Classes/Domain/Model/ImageVariant.php b/Neos.Media/Classes/Domain/Model/ImageVariant.php index 3fc53b5b0ee..01a6b6476a3 100644 --- a/Neos.Media/Classes/Domain/Model/ImageVariant.php +++ b/Neos.Media/Classes/Domain/Model/ImageVariant.php @@ -17,6 +17,7 @@ use Doctrine\ORM\Mapping as ORM; use Neos\Flow\Annotations as Flow; use Neos\Flow\Configuration\Exception\InvalidConfigurationException; +use Neos\Flow\ObjectManagement\DependencyInjection\DependencyProxy; use Neos\Flow\ObjectManagement\ObjectManagerInterface; use Neos\Flow\ResourceManagement\Exception; use Neos\Flow\ResourceManagement\PersistentResource; @@ -94,6 +95,12 @@ public function __construct(Image $originalAsset) } catch (\Exception $e) { // This won't happen, because we create DateTime without any parameters. } + + $originalAssetCollections = $originalAsset->getAssetCollections(); + if ($originalAssetCollections instanceof DependencyProxy) { + $originalAssetCollections->_activateDependency(); + } + $this->setAssetCollections($originalAssetCollections); } /** diff --git a/Neos.Neos/Classes/Controller/Module/Administration/UsersController.php b/Neos.Neos/Classes/Controller/Module/Administration/UsersController.php index 430aca6b8c2..c91ceee1e55 100644 --- a/Neos.Neos/Classes/Controller/Module/Administration/UsersController.php +++ b/Neos.Neos/Classes/Controller/Module/Administration/UsersController.php @@ -505,7 +505,7 @@ protected function assignElectronicAddressOptions(): void $electronicAddressUsageTypes = []; $translationHelper = new TranslationHelper(); foreach ($electronicAddress->getAvailableUsageTypes() as $type) { - $electronicAddressUsageTypes[$type] = $translationHelper->translate('users.electronicAddress.usage.type.' . $type, $type, [], 'Modules', 'Neos.Neos'); + $electronicAddressUsageTypes[$type] = $type; } array_unshift($electronicAddressUsageTypes, ''); $this->view->assignMultiple([ diff --git a/Neos.Neos/Classes/Service/LinkingService.php b/Neos.Neos/Classes/Service/LinkingService.php index 5355f8125e8..d205eba8320 100644 --- a/Neos.Neos/Classes/Service/LinkingService.php +++ b/Neos.Neos/Classes/Service/LinkingService.php @@ -134,7 +134,7 @@ public function hasSupportedScheme($uri): bool $uri = (string)$uri; } - return preg_match(self::PATTERN_SUPPORTED_URIS, $uri) === 1; + return $uri !== null && preg_match(self::PATTERN_SUPPORTED_URIS, $uri) === 1; } /** @@ -147,7 +147,7 @@ public function getScheme($uri): string return $uri->getScheme(); } - if (preg_match(self::PATTERN_SUPPORTED_URIS, $uri, $matches) === 1) { + if ($uri !== null && preg_match(self::PATTERN_SUPPORTED_URIS, $uri, $matches) === 1) { return $matches[1]; } diff --git a/Neos.Neos/Documentation/Appendixes/ChangeLogs/7314.rst b/Neos.Neos/Documentation/Appendixes/ChangeLogs/7314.rst new file mode 100644 index 00000000000..3d8b38ca9da --- /dev/null +++ b/Neos.Neos/Documentation/Appendixes/ChangeLogs/7314.rst @@ -0,0 +1,179 @@ +`7.3.14 (2023-07-18) `_ +================================================================================================ + +Overview of merged pull requests +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +`BUGFIX: Disable content element wrapping and inline editable for references in content reference list `_ +------------------------------------------------------------------------------------------------------------------------------------------------------------------------ + +The NeosUI tries to initialize the inline editor for rendered references in content reference list. But they are not accessable at this moment. As references shouldn't get edited anyways, we can simple disable the content element wrapping for these references. + +Fixes https://github.com/neos/neos-ui/issues/3574 + +* Packages: ``Neos`` ``NodeTypes.ContentReferences`` + +`BUGFIX: Disable publish checkmark for new pages in workspace `_ +------------------------------------------------------------------------------------------------------------------------------- + +closes `#3991 `_ + +**Review instructions** +If the document is new, I show a small disabled checkmark instead of the functioning checkmark. This will force the user to use the checkboxes on the left side to publish changes. +This does not solve the underlying problem but it will at least disable the function for Editors. + +Bildschirmfoto 2023-05-12 um 11 12 21 + + +* Packages: ``Neos`` + +`BUGFIX: Allow string position values in NodeType schema `_ +-------------------------------------------------------------------------------------------------------------------------- + +The PositionalArraySorter implementation allows string values for the position of nodetypes, tabs, groups and views since a long time but the schema validation showed warnings. + +**Review instructions** + +Open the ``NodeTypes`` tab in the ``Configuration`` module with the Neos.Demo and the previous validation warnings shouldn't show up anymore. + + +* Packages: ``Neos`` + +`BUGFIX: Undefined array key "ui" in nodeType creationDialog `_ +------------------------------------------------------------------------------------------------------------------------------ + +Currently, its not possible to use the shorthand +```yaml + creationDialog: + elements: + hasFoo: + type: boolean + # ui: {} # this must be set to an empty array +``` + +as there is an unsafe access on the ui property +> Warning: Undefined array key "ui" in /Data/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Neos_NodeTypePostprocessor_DefaultPropertyEditorPostprocessor.php line 110 + + + +regression from `#3473 `_ + +**Upgrade instructions** + +**Review instructions** + + +* Packages: ``Neos`` + +`BUGFIX: flow command typo in exception in nearestContentCollection method `_ +-------------------------------------------------------------------------------------------------------------------------------------------- + +**Upgrade instructions** + +_None_ + +**Review instructions** + +Command in exception should be start with ``./flow command...`` and not ``flow command...`` + +!`SCR-20230605-jytx `_ + + + +* Packages: ``Neos`` + +`BUGFIX: CreationDialog hideable elements `_ +----------------------------------------------------------------------------------------------------------- + +closes cross repo issue: https://github.com/neos/neos-ui/issues/3483 + +In the UI it will be once https://github.com/neos/neos-ui/pull/3507 is merged possible to use the ``hidden`` property in the node creation dialog + +```yaml +ui: + creationDialog: + elements: + hiddenProperty: + type: string + ui: + hidden: true +``` + +This change adjusts neos creationDialogPostprocessor so that creationDialog items that are generated from properties via ``showInCreationDialog`` will have the hidden property copied + +```yaml +properties: + hiddenProperty: + type: string + ui: + showInCreationDialog: true + inspector: + hidden: true +``` + +**Upgrade instructions** + +**Review instructions** + + +* Packages: ``ContentRepository`` ``Fusion.Afx`` ``Neos`` + +`TASK: add default value for generatorName at kickstart command in SiteKickstarter `_ +---------------------------------------------------------------------------------------------------------------------------------------------------- + +We tried to reproduce #4053. +We can't reproduce this issue, but while reproducing we found a flow command prompt, without a default value. + +The command ``flow kickstart:site AnySite.Site`` asks for a site generator. +We added a default value by adding: +```php +array_key_first($selection) +``` + +**Review instructions** +At https://github.com/neos/neos-development-collection/blob/`79dd4e1a26b7ffceb80cc628fdbe570ff6013b16 ``_/Neos.CliSetup/Classes/Command/SetupCommandController.php#L165 ``array_key_last`` is used. Should we use ``array_key_last`` too or is ``array_key_first` fine for it? + + +* Packages: ``SiteKickstarter`` + +`TASK: PHP 8.1 deprecations compatibility `_ +----------------------------------------------------------------------------------------------------------- + +This tweaks the code so that it runs without deprecations on PHP 8.1. + +**Upgrade instructions** + +None. + +**Review instructions** + +None. + + +* Packages: ``Fusion`` ``Neos`` + +`TASK: Change variablename in Neos Fusion documentation `_ +------------------------------------------------------------------------------------------------------------------------- + +Now use "myString" in documentation, because the return value is a string and not an array. This can lead to confusion under certain circumstances. + +**Upgrade instructions** + +**Review instructions** + + +* Packages: ``Neos`` + +`TASK: Apply fixes from StyleCI `_ +------------------------------------------------------------------------------------------------- + +This pull request applies code style fixes from an analysis carried out by `StyleCI `_. + +--- + +For more information, click `here `_. + +* Packages: ``Neos`` ``ContentRepository`` ``Fusion.Afx`` ``Fusion`` ``Media`` ``SiteKickstarter`` + +`Detailed log `_ +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/Neos.Neos/Documentation/Appendixes/ChangeLogs/8011.rst b/Neos.Neos/Documentation/Appendixes/ChangeLogs/8011.rst new file mode 100644 index 00000000000..a16fce49016 --- /dev/null +++ b/Neos.Neos/Documentation/Appendixes/ChangeLogs/8011.rst @@ -0,0 +1,187 @@ +`8.0.11 (2023-07-18) `_ +================================================================================================ + +Overview of merged pull requests +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +`BUGFIX: Disable content element wrapping and inline editable for references in content reference list `_ +------------------------------------------------------------------------------------------------------------------------------------------------------------------------ + +The NeosUI tries to initialize the inline editor for rendered references in content reference list. But they are not accessable at this moment. As references shouldn't get edited anyways, we can simple disable the content element wrapping for these references. + +Fixes https://github.com/neos/neos-ui/issues/3574 + +* Packages: ``Neos`` ``NodeTypes.ContentReferences`` + +`BUGFIX: Disable publish checkmark for new pages in workspace `_ +------------------------------------------------------------------------------------------------------------------------------- + +closes `#3991 `_ + +**Review instructions** +If the document is new, I show a small disabled checkmark instead of the functioning checkmark. This will force the user to use the checkboxes on the left side to publish changes. +This does not solve the underlying problem but it will at least disable the function for Editors. + +Bildschirmfoto 2023-05-12 um 11 12 21 + + +* Packages: ``Neos`` + +`BUGFIX: Fusion's FilePatternResolver windows compatible `_ +-------------------------------------------------------------------------------------------------------------------------- + +resolves `#4358 ``_in combination with ``#4374 `_ + + +The FilePatternResolver is responsible to handle glob patterns in includes in fusion. +For more in depth information see the test: https://github.com/neos/neos-development-collection/blob/`a461dbc8f976588b30f34a5ed34f1eeebf5a0cd2 `_/Neos.Fusion/Tests/Unit/Core/Parser/ParserIncludeTest.php#L156-L167 + +**Upgrade instructions** + + +* Packages: ``Neos`` ``Fusion`` + +`BUGFIX: Allow string position values in NodeType schema `_ +-------------------------------------------------------------------------------------------------------------------------- + +The PositionalArraySorter implementation allows string values for the position of nodetypes, tabs, groups and views since a long time but the schema validation showed warnings. + +**Review instructions** + +Open the ``NodeTypes`` tab in the ``Configuration`` module with the Neos.Demo and the previous validation warnings shouldn't show up anymore. + + +* Packages: ``Neos`` + +`BUGFIX: Undefined array key "ui" in nodeType creationDialog `_ +------------------------------------------------------------------------------------------------------------------------------ + +Currently, its not possible to use the shorthand +```yaml + creationDialog: + elements: + hasFoo: + type: boolean + # ui: {} # this must be set to an empty array +``` + +as there is an unsafe access on the ui property +> Warning: Undefined array key "ui" in /Data/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Neos_NodeTypePostprocessor_DefaultPropertyEditorPostprocessor.php line 110 + + + +regression from `#3473 `_ + +**Upgrade instructions** + + +* Packages: ``Neos`` + +`BUGFIX: flow command typo in exception in nearestContentCollection method `_ +-------------------------------------------------------------------------------------------------------------------------------------------- + +**Upgrade instructions** + +_None_ + +**Review instructions** + +Command in exception should be start with ``./flow command...`` and not ``flow command...`` + +!`SCR-20230605-jytx `_ + + + +* Packages: ``Neos`` + +`BUGFIX: CreationDialog hideable elements `_ +----------------------------------------------------------------------------------------------------------- + +closes cross repo issue: https://github.com/neos/neos-ui/issues/3483 + +In the UI it will be once https://github.com/neos/neos-ui/pull/3507 is merged possible to use the ``hidden`` property in the node creation dialog + +```yaml +ui: + creationDialog: + elements: + hiddenProperty: + type: string + ui: + hidden: true +``` + +This change adjusts neos creationDialogPostprocessor so that creationDialog items that are generated from properties via ``showInCreationDialog`` will have the hidden property copied + +```yaml +properties: + hiddenProperty: + type: string + ui: + showInCreationDialog: true + inspector: + hidden: true +``` + +**Upgrade instructions** + + +* Packages: ``ContentRepository`` ``Fusion.Afx`` ``Neos`` + +`TASK: add default value for generatorName at kickstart command in SiteKickstarter `_ +---------------------------------------------------------------------------------------------------------------------------------------------------- + +We tried to reproduce #4053. +We can't reproduce this issue, but while reproducing we found a flow command prompt, without a default value. + +The command ``flow kickstart:site AnySite.Site`` asks for a site generator. +We added a default value by adding: +```php +array_key_first($selection) +``` + +**Review instructions** +At https://github.com/neos/neos-development-collection/blob/`79dd4e1a26b7ffceb80cc628fdbe570ff6013b16 ``_/Neos.CliSetup/Classes/Command/SetupCommandController.php#L165 ``array_key_last`` is used. Should we use ``array_key_last`` too or is ``array_key_first` fine for it? + + +* Packages: ``SiteKickstarter`` + +`TASK: PHP 8.1 deprecations compatibility `_ +----------------------------------------------------------------------------------------------------------- + +This tweaks the code so that it runs without deprecations on PHP 8.1. + +**Upgrade instructions** + +None. + +**Review instructions** + +None. + + +* Packages: ``Fusion`` ``Neos`` + +`TASK: Change variablename in Neos Fusion documentation `_ +------------------------------------------------------------------------------------------------------------------------- + +Now use "myString" in documentation, because the return value is a string and not an array. This can lead to confusion under certain circumstances. + +**Upgrade instructions** + + +* Packages: ``Neos`` + +`TASK: Apply fixes from StyleCI `_ +------------------------------------------------------------------------------------------------- + +This pull request applies code style fixes from an analysis carried out by `StyleCI `_. + +--- + +For more information, click `here `_. + +* Packages: ``Neos`` ``ContentRepository`` ``Fusion.Afx`` ``Fusion`` ``Media`` ``SiteKickstarter`` + +`Detailed log `_ +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/Neos.Neos/Documentation/Appendixes/ChangeLogs/816.rst b/Neos.Neos/Documentation/Appendixes/ChangeLogs/816.rst new file mode 100644 index 00000000000..8737836d02d --- /dev/null +++ b/Neos.Neos/Documentation/Appendixes/ChangeLogs/816.rst @@ -0,0 +1,187 @@ +`8.1.6 (2023-07-18) `_ +============================================================================================== + +Overview of merged pull requests +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +`BUGFIX: Disable content element wrapping and inline editable for references in content reference list `_ +------------------------------------------------------------------------------------------------------------------------------------------------------------------------ + +The NeosUI tries to initialize the inline editor for rendered references in content reference list. But they are not accessable at this moment. As references shouldn't get edited anyways, we can simple disable the content element wrapping for these references. + +Fixes https://github.com/neos/neos-ui/issues/3574 + +* Packages: ``Neos`` ``NodeTypes.ContentReferences`` + +`BUGFIX: Disable publish checkmark for new pages in workspace `_ +------------------------------------------------------------------------------------------------------------------------------- + +closes `#3991 `_ + +**Review instructions** +If the document is new, I show a small disabled checkmark instead of the functioning checkmark. This will force the user to use the checkboxes on the left side to publish changes. +This does not solve the underlying problem but it will at least disable the function for Editors. + +Bildschirmfoto 2023-05-12 um 11 12 21 + + +* Packages: ``Neos`` + +`BUGFIX: Fusion's FilePatternResolver windows compatible `_ +-------------------------------------------------------------------------------------------------------------------------- + +resolves `#4358 ``_in combination with ``#4374 `_ + + +The FilePatternResolver is responsible to handle glob patterns in includes in fusion. +For more in depth information see the test: https://github.com/neos/neos-development-collection/blob/`a461dbc8f976588b30f34a5ed34f1eeebf5a0cd2 `_/Neos.Fusion/Tests/Unit/Core/Parser/ParserIncludeTest.php#L156-L167 + +**Upgrade instructions** + + +* Packages: ``Neos`` ``Fusion`` + +`BUGFIX: Allow string position values in NodeType schema `_ +-------------------------------------------------------------------------------------------------------------------------- + +The PositionalArraySorter implementation allows string values for the position of nodetypes, tabs, groups and views since a long time but the schema validation showed warnings. + +**Review instructions** + +Open the ``NodeTypes`` tab in the ``Configuration`` module with the Neos.Demo and the previous validation warnings shouldn't show up anymore. + + +* Packages: ``Neos`` + +`BUGFIX: Undefined array key "ui" in nodeType creationDialog `_ +------------------------------------------------------------------------------------------------------------------------------ + +Currently, its not possible to use the shorthand +```yaml + creationDialog: + elements: + hasFoo: + type: boolean + # ui: {} # this must be set to an empty array +``` + +as there is an unsafe access on the ui property +> Warning: Undefined array key "ui" in /Data/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Neos_NodeTypePostprocessor_DefaultPropertyEditorPostprocessor.php line 110 + + + +regression from `#3473 `_ + +**Upgrade instructions** + + +* Packages: ``Neos`` + +`BUGFIX: flow command typo in exception in nearestContentCollection method `_ +-------------------------------------------------------------------------------------------------------------------------------------------- + +**Upgrade instructions** + +_None_ + +**Review instructions** + +Command in exception should be start with ``./flow command...`` and not ``flow command...`` + +!`SCR-20230605-jytx `_ + + + +* Packages: ``Neos`` + +`BUGFIX: CreationDialog hideable elements `_ +----------------------------------------------------------------------------------------------------------- + +closes cross repo issue: https://github.com/neos/neos-ui/issues/3483 + +In the UI it will be once https://github.com/neos/neos-ui/pull/3507 is merged possible to use the ``hidden`` property in the node creation dialog + +```yaml +ui: + creationDialog: + elements: + hiddenProperty: + type: string + ui: + hidden: true +``` + +This change adjusts neos creationDialogPostprocessor so that creationDialog items that are generated from properties via ``showInCreationDialog`` will have the hidden property copied + +```yaml +properties: + hiddenProperty: + type: string + ui: + showInCreationDialog: true + inspector: + hidden: true +``` + +**Upgrade instructions** + + +* Packages: ``ContentRepository`` ``Fusion.Afx`` ``Neos`` + +`TASK: add default value for generatorName at kickstart command in SiteKickstarter `_ +---------------------------------------------------------------------------------------------------------------------------------------------------- + +We tried to reproduce #4053. +We can't reproduce this issue, but while reproducing we found a flow command prompt, without a default value. + +The command ``flow kickstart:site AnySite.Site`` asks for a site generator. +We added a default value by adding: +```php +array_key_first($selection) +``` + +**Review instructions** +At https://github.com/neos/neos-development-collection/blob/`79dd4e1a26b7ffceb80cc628fdbe570ff6013b16 ``_/Neos.CliSetup/Classes/Command/SetupCommandController.php#L165 ``array_key_last`` is used. Should we use ``array_key_last`` too or is ``array_key_first` fine for it? + + +* Packages: ``SiteKickstarter`` + +`TASK: PHP 8.1 deprecations compatibility `_ +----------------------------------------------------------------------------------------------------------- + +This tweaks the code so that it runs without deprecations on PHP 8.1. + +**Upgrade instructions** + +None. + +**Review instructions** + +None. + + +* Packages: ``Fusion`` ``Neos`` + +`TASK: Change variablename in Neos Fusion documentation `_ +------------------------------------------------------------------------------------------------------------------------- + +Now use "myString" in documentation, because the return value is a string and not an array. This can lead to confusion under certain circumstances. + +**Upgrade instructions** + + +* Packages: ``Neos`` + +`TASK: Apply fixes from StyleCI `_ +------------------------------------------------------------------------------------------------- + +This pull request applies code style fixes from an analysis carried out by `StyleCI `_. + +--- + +For more information, click `here `_. + +* Packages: ``Neos`` ``ContentRepository`` ``Fusion.Afx`` ``Fusion`` ``Media`` ``SiteKickstarter`` + +`Detailed log `_ +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/Neos.Neos/Documentation/Appendixes/ChangeLogs/826.rst b/Neos.Neos/Documentation/Appendixes/ChangeLogs/826.rst new file mode 100644 index 00000000000..fd96bbe23a9 --- /dev/null +++ b/Neos.Neos/Documentation/Appendixes/ChangeLogs/826.rst @@ -0,0 +1,187 @@ +`8.2.6 (2023-07-18) `_ +============================================================================================== + +Overview of merged pull requests +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +`BUGFIX: Disable content element wrapping and inline editable for references in content reference list `_ +------------------------------------------------------------------------------------------------------------------------------------------------------------------------ + +The NeosUI tries to initialize the inline editor for rendered references in content reference list. But they are not accessable at this moment. As references shouldn't get edited anyways, we can simple disable the content element wrapping for these references. + +Fixes https://github.com/neos/neos-ui/issues/3574 + +* Packages: ``Neos`` ``NodeTypes.ContentReferences`` + +`BUGFIX: Disable publish checkmark for new pages in workspace `_ +------------------------------------------------------------------------------------------------------------------------------- + +closes `#3991 `_ + +**Review instructions** +If the document is new, I show a small disabled checkmark instead of the functioning checkmark. This will force the user to use the checkboxes on the left side to publish changes. +This does not solve the underlying problem but it will at least disable the function for Editors. + +Bildschirmfoto 2023-05-12 um 11 12 21 + + +* Packages: ``Neos`` + +`BUGFIX: Fusion's FilePatternResolver windows compatible `_ +-------------------------------------------------------------------------------------------------------------------------- + +resolves `#4358 ``_in combination with ``#4374 `_ + + +The FilePatternResolver is responsible to handle glob patterns in includes in fusion. +For more in depth information see the test: https://github.com/neos/neos-development-collection/blob/`a461dbc8f976588b30f34a5ed34f1eeebf5a0cd2 `_/Neos.Fusion/Tests/Unit/Core/Parser/ParserIncludeTest.php#L156-L167 + +**Upgrade instructions** + + +* Packages: ``Neos`` ``Fusion`` + +`BUGFIX: Allow string position values in NodeType schema `_ +-------------------------------------------------------------------------------------------------------------------------- + +The PositionalArraySorter implementation allows string values for the position of nodetypes, tabs, groups and views since a long time but the schema validation showed warnings. + +**Review instructions** + +Open the ``NodeTypes`` tab in the ``Configuration`` module with the Neos.Demo and the previous validation warnings shouldn't show up anymore. + + +* Packages: ``Neos`` + +`BUGFIX: Undefined array key "ui" in nodeType creationDialog `_ +------------------------------------------------------------------------------------------------------------------------------ + +Currently, its not possible to use the shorthand +```yaml + creationDialog: + elements: + hasFoo: + type: boolean + # ui: {} # this must be set to an empty array +``` + +as there is an unsafe access on the ui property +> Warning: Undefined array key "ui" in /Data/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Neos_NodeTypePostprocessor_DefaultPropertyEditorPostprocessor.php line 110 + + + +regression from `#3473 `_ + +**Upgrade instructions** + + +* Packages: ``Neos`` + +`BUGFIX: flow command typo in exception in nearestContentCollection method `_ +-------------------------------------------------------------------------------------------------------------------------------------------- + +**Upgrade instructions** + +_None_ + +**Review instructions** + +Command in exception should be start with ``./flow command...`` and not ``flow command...`` + +!`SCR-20230605-jytx `_ + + + +* Packages: ``Neos`` + +`BUGFIX: CreationDialog hideable elements `_ +----------------------------------------------------------------------------------------------------------- + +closes cross repo issue: https://github.com/neos/neos-ui/issues/3483 + +In the UI it will be once https://github.com/neos/neos-ui/pull/3507 is merged possible to use the ``hidden`` property in the node creation dialog + +```yaml +ui: + creationDialog: + elements: + hiddenProperty: + type: string + ui: + hidden: true +``` + +This change adjusts neos creationDialogPostprocessor so that creationDialog items that are generated from properties via ``showInCreationDialog`` will have the hidden property copied + +```yaml +properties: + hiddenProperty: + type: string + ui: + showInCreationDialog: true + inspector: + hidden: true +``` + +**Upgrade instructions** + + +* Packages: ``ContentRepository`` ``Fusion.Afx`` ``Neos`` + +`TASK: add default value for generatorName at kickstart command in SiteKickstarter `_ +---------------------------------------------------------------------------------------------------------------------------------------------------- + +We tried to reproduce #4053. +We can't reproduce this issue, but while reproducing we found a flow command prompt, without a default value. + +The command ``flow kickstart:site AnySite.Site`` asks for a site generator. +We added a default value by adding: +```php +array_key_first($selection) +``` + +**Review instructions** +At https://github.com/neos/neos-development-collection/blob/`79dd4e1a26b7ffceb80cc628fdbe570ff6013b16 ``_/Neos.CliSetup/Classes/Command/SetupCommandController.php#L165 ``array_key_last`` is used. Should we use ``array_key_last`` too or is ``array_key_first` fine for it? + + +* Packages: ``SiteKickstarter`` + +`TASK: PHP 8.1 deprecations compatibility `_ +----------------------------------------------------------------------------------------------------------- + +This tweaks the code so that it runs without deprecations on PHP 8.1. + +**Upgrade instructions** + +None. + +**Review instructions** + +None. + + +* Packages: ``Fusion`` ``Neos`` + +`TASK: Change variablename in Neos Fusion documentation `_ +------------------------------------------------------------------------------------------------------------------------- + +Now use "myString" in documentation, because the return value is a string and not an array. This can lead to confusion under certain circumstances. + +**Upgrade instructions** + + +* Packages: ``Neos`` + +`TASK: Apply fixes from StyleCI `_ +------------------------------------------------------------------------------------------------- + +This pull request applies code style fixes from an analysis carried out by `StyleCI `_. + +--- + +For more information, click `here `_. + +* Packages: ``Neos`` ``ContentRepository`` ``Fusion.Afx`` ``Fusion`` ``Media`` ``SiteKickstarter`` + +`Detailed log `_ +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/Neos.Neos/Documentation/Appendixes/ChangeLogs/834.rst b/Neos.Neos/Documentation/Appendixes/ChangeLogs/834.rst new file mode 100644 index 00000000000..098cb486eef --- /dev/null +++ b/Neos.Neos/Documentation/Appendixes/ChangeLogs/834.rst @@ -0,0 +1,196 @@ +`8.3.4 (2023-07-18) `_ +============================================================================================== + +Overview of merged pull requests +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +`BUGFIX: Disable content element wrapping and inline editable for references in content reference list `_ +------------------------------------------------------------------------------------------------------------------------------------------------------------------------ + +The NeosUI tries to initialize the inline editor for rendered references in content reference list. But they are not accessable at this moment. As references shouldn't get edited anyways, we can simple disable the content element wrapping for these references. + +Fixes https://github.com/neos/neos-ui/issues/3574 + +* Packages: ``Neos`` ``NodeTypes.ContentReferences`` + +`BUGFIX: Disable publish checkmark for new pages in workspace `_ +------------------------------------------------------------------------------------------------------------------------------- + +closes `#3991 `_ + +**Review instructions** +If the document is new, I show a small disabled checkmark instead of the functioning checkmark. This will force the user to use the checkboxes on the left side to publish changes. +This does not solve the underlying problem but it will at least disable the function for Editors. + +Bildschirmfoto 2023-05-12 um 11 12 21 + + +* Packages: ``Neos`` + +`BUGFIX: Fusion's FilePatternResolver windows compatible `_ +-------------------------------------------------------------------------------------------------------------------------- + +resolves `#4358 ``_in combination with ``#4374 `_ + + +The FilePatternResolver is responsible to handle glob patterns in includes in fusion. +For more in depth information see the test: https://github.com/neos/neos-development-collection/blob/`a461dbc8f976588b30f34a5ed34f1eeebf5a0cd2 `_/Neos.Fusion/Tests/Unit/Core/Parser/ParserIncludeTest.php#L156-L167 + +**Upgrade instructions** + + +* Packages: ``Neos`` ``Fusion`` + +`BUGFIX: Allow string position values in NodeType schema `_ +-------------------------------------------------------------------------------------------------------------------------- + +The PositionalArraySorter implementation allows string values for the position of nodetypes, tabs, groups and views since a long time but the schema validation showed warnings. + +**Review instructions** + +Open the ``NodeTypes`` tab in the ``Configuration`` module with the Neos.Demo and the previous validation warnings shouldn't show up anymore. + + +* Packages: ``Neos`` + +`BUGFIX: Undefined array key "ui" in nodeType creationDialog `_ +------------------------------------------------------------------------------------------------------------------------------ + +Currently, its not possible to use the shorthand +```yaml + creationDialog: + elements: + hasFoo: + type: boolean + # ui: {} # this must be set to an empty array +``` + +as there is an unsafe access on the ui property +> Warning: Undefined array key "ui" in /Data/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Neos_NodeTypePostprocessor_DefaultPropertyEditorPostprocessor.php line 110 + + + +regression from `#3473 `_ + +**Upgrade instructions** + + +* Packages: ``Neos`` + +`BUGFIX: flow command typo in exception in nearestContentCollection method `_ +-------------------------------------------------------------------------------------------------------------------------------------------- + +**Upgrade instructions** + +_None_ + +**Review instructions** + +Command in exception should be start with ``./flow command...`` and not ``flow command...`` + +!`SCR-20230605-jytx `_ + + + +* Packages: ``Neos`` + +`BUGFIX: CreationDialog hideable elements `_ +----------------------------------------------------------------------------------------------------------- + +closes cross repo issue: https://github.com/neos/neos-ui/issues/3483 + +In the UI it will be once https://github.com/neos/neos-ui/pull/3507 is merged possible to use the ``hidden`` property in the node creation dialog + +```yaml +ui: + creationDialog: + elements: + hiddenProperty: + type: string + ui: + hidden: true +``` + +This change adjusts neos creationDialogPostprocessor so that creationDialog items that are generated from properties via ``showInCreationDialog`` will have the hidden property copied + +```yaml +properties: + hiddenProperty: + type: string + ui: + showInCreationDialog: true + inspector: + hidden: true +``` + +**Upgrade instructions** + + +* Packages: ``ContentRepository`` ``Fusion.Afx`` ``Neos`` + +`TASK: add default value for generatorName at kickstart command in SiteKickstarter `_ +---------------------------------------------------------------------------------------------------------------------------------------------------- + +We tried to reproduce #4053. +We can't reproduce this issue, but while reproducing we found a flow command prompt, without a default value. + +The command ``flow kickstart:site AnySite.Site`` asks for a site generator. +We added a default value by adding: +```php +array_key_first($selection) +``` + +**Review instructions** +At https://github.com/neos/neos-development-collection/blob/`79dd4e1a26b7ffceb80cc628fdbe570ff6013b16 ``_/Neos.CliSetup/Classes/Command/SetupCommandController.php#L165 ``array_key_last`` is used. Should we use ``array_key_last`` too or is ``array_key_first` fine for it? + + +* Packages: ``SiteKickstarter`` + +`TASK: PHP 8.1 deprecations compatibility `_ +----------------------------------------------------------------------------------------------------------- + +This tweaks the code so that it runs without deprecations on PHP 8.1. + +**Upgrade instructions** + +None. + +**Review instructions** + +None. + + +* Packages: ``Fusion`` ``Neos`` + +`TASK: Change variablename in Neos Fusion documentation `_ +------------------------------------------------------------------------------------------------------------------------- + +Now use "myString" in documentation, because the return value is a string and not an array. This can lead to confusion under certain circumstances. + +**Upgrade instructions** + + +* Packages: ``Neos`` + +`TASK: Adjust link editor documentation `_ +--------------------------------------------------------------------------------------------------------- + +Tiny mistake in link editor documentation: +To refer to another node type the reference **property** type is used, not the reference node type. + + +* Packages: ``Neos`` + +`TASK: Apply fixes from StyleCI `_ +------------------------------------------------------------------------------------------------- + +This pull request applies code style fixes from an analysis carried out by `StyleCI `_. + +--- + +For more information, click `here `_. + +* Packages: ``Neos`` ``ContentRepository`` ``Fusion.Afx`` ``Fusion`` ``Media`` ``SiteKickstarter`` + +`Detailed log `_ +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/Neos.Neos/Documentation/References/NodeTypeDefinition.rst b/Neos.Neos/Documentation/References/NodeTypeDefinition.rst index 884535de5ed..125354fd7b2 100644 --- a/Neos.Neos/Documentation/References/NodeTypeDefinition.rst +++ b/Neos.Neos/Documentation/References/NodeTypeDefinition.rst @@ -152,7 +152,7 @@ The following options are allowed for defining a NodeType: Fontawesome icon: All free Fontawesome 5 icons can be used: - https://fontawesome.com/icons?d=gallery&m=free + https://fontawesome.com/v5/search?o=r&m=free Those can be referenced via "icon-[name]", as the UI includes a fallback to the "fas" prefix-classes. To be sure which icon will be used, they can also be referenced by their diff --git a/Neos.Neos/Resources/Private/Partials/Module/Shared/EditUser.html b/Neos.Neos/Resources/Private/Partials/Module/Shared/EditUser.html index f4caf552c77..94c3b3c7e87 100644 --- a/Neos.Neos/Resources/Private/Partials/Module/Shared/EditUser.html +++ b/Neos.Neos/Resources/Private/Partials/Module/Shared/EditUser.html @@ -107,7 +107,7 @@
- +
diff --git a/Neos.Neos/Resources/Private/Partials/Module/Shared/NewElectronicAddress.html b/Neos.Neos/Resources/Private/Partials/Module/Shared/NewElectronicAddress.html index e5a2b6255a7..3c1ccdea260 100644 --- a/Neos.Neos/Resources/Private/Partials/Module/Shared/NewElectronicAddress.html +++ b/Neos.Neos/Resources/Private/Partials/Module/Shared/NewElectronicAddress.html @@ -25,7 +25,7 @@ diff --git a/Neos.Neos/Resources/Public/JavaScript/Templates/ImpersonateButton.js b/Neos.Neos/Resources/Public/JavaScript/Templates/ImpersonateButton.js index af84b808e61..15ac6b5b6ed 100644 --- a/Neos.Neos/Resources/Public/JavaScript/Templates/ImpersonateButton.js +++ b/Neos.Neos/Resources/Public/JavaScript/Templates/ImpersonateButton.js @@ -8,7 +8,7 @@ const localizedTooltip = !isNil(window.Typo3Neos) ? const ImpersonateButton = (identifier, disabled) => { const attributesObject = { 'data-neos-toggle': 'tooltip', - 'data-original-title': localizedTooltip, + 'title': localizedTooltip, 'data-user-identifier': identifier, class: 'neos-button neos-button-primary impersonate-user', }