Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeRenderable does not set new index #150

Closed
reflexxion opened this issue Dec 9, 2021 · 0 comments · Fixed by #151
Closed

removeRenderable does not set new index #150

reflexxion opened this issue Dec 9, 2021 · 0 comments · Fixed by #151

Comments

@reflexxion
Copy link
Contributor

AbstractCompositeRenderable::removeRenderable does not set the new indexes to the renderables (as moveRenderable(Before|After) does).
So removing a page results in wrong pagination.
reflexxion added a commit to reflexxion/form that referenced this issue Dec 9, 2021
@reflexxion
BUGFIX: Reindex renderables on remove
b7664e2 
Removing a renderable should set index of renderables as move does

Fixes neos#150
@reflexxion reflexxion mentioned this issue Dec 9, 2021
Merged
reflexxion added a commit to reflexxion/form that referenced this issue Dec 9, 2021
@reflexxion
BUGFIX: Reindex renderables on remove
45bc3c1 
Removing a renderable should set index of renderables as move does

Fixes neos#150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUGFIX: Reindex renderables on remove reflexxion/form
1 participant
@reflexxion