Make allowed_classes configurable when unserializing formState #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaidelich
reviewed
Jul 28, 2021
bwaidelich
reviewed
Jul 28, 2021
bwaidelich
approved these changes
Jul 28, 2021
|
I'm just not sure about the target branch. IIRC features can only go into a |
|
I can change the target branch to |
yes please. Thanks |
|
@ger4003 Just a little update: I'm currently reviewing this and the change works great, but we are currently discussing whether the |
bwaidelich
requested changes
Aug 5, 2021
There was a problem hiding this comment.
And here is the update:
I think this one is obsolete with #145 and can be closed.
Thanks again and sorry for the inconvenience!
|
#close in favor of #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a new configuration option it is possible to add class names to
allowed_classesforunserialize()formState withinFormRuntime::initializeFormStateFromRequestcloses #143