Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Replace preg_replace with PSR-7 UriInterface method for action uri #132

Merged
merged 1 commit into from
Jan 11, 2021
Merged

TASK: Replace preg_replace with PSR-7 UriInterface method for action uri #132

merged 1 commit into from
Jan 11, 2021

Conversation

sorenmalling
Copy link
Contributor

Resolves #131

bwaidelich
bwaidelich approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

@bwaidelich bwaidelich merged commit ddc25b3 into neos:master Jan 11, 2021
@Sebobo
Copy link
Member

Sebobo commented Mar 12, 2021

This seems to be very kaputt. section is not set as $uri->withFragment($this->hasArgument('section')); does neither update the uri nor set the correct value.
I'm working on a fix.

@Sebobo
Copy link
Member

Sebobo commented Mar 12, 2021

Noticed as I wanted to release but the tests fail.

@sorenmalling
Copy link
Contributor Author

Noticed as I wanted to release but the tests fail.

What test, where?

@Sebobo
Copy link
Member

Sebobo commented Mar 12, 2021 •
edited
Loading

Neos\Form\Tests\Unit\ViewHelpers\FormViewHelperTest::getFormActionUriTest

@Sebobo Sebobo mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FormViewHelper generates empty fragment for action uri due to preg_replace and missing conditino
3 participants
@sorenmalling @Sebobo @bwaidelich