Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormViewHelper generates empty fragment for action uri due to preg_replace and missing conditino #131

Closed
sorenmalling opened this issue Jan 9, 2021 · 0 comments · Fixed by #132

Comments

@sorenmalling
Copy link
Contributor

The current action uri can get a section added (the #[section] value of a uri).

This is done by check if the argument has a value (empty string included) and with preg_replace, the value is added.

Since we get a UriInterface object, we can use the withFragment instead, but it requires a stricter check for the section value, since it does not accept a empty string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant