Deploying an extension from github

[asmodeus812]

Hi, i am having a few questions on the workflow on pulling an extension from github. It is possible to do something like CocInstall https://github.com/repo/ext, and the extension will be pulled, however the build process i think is not handled well by coc.

Here from the source.

public getInstallArguments(exePath: string, url: string | undefined): string[] {
    let args = ['install', '--ignore-scripts', '--no-lockfile']
    if (url && url.startsWith('https://github.com')) {
      args = ['install']
    }
    if (isNpmCommand(exePath)) {
      args.push('--omit=dev')
      args.push('--legacy-peer-deps')
      args.push('--no-global')
    }
    if (isYarn(exePath)) {
      args.push('--production')
      args.push('--ignore-engines')
    }
    if (isPnpm(exePath)) {
      args.push('--production')
      args.push('--config.strict-peer-dependencies=false')
    }
    return args
  }

We can see that if we have a github uri it will try to run install which is great, however, it will also try to build with --omit=dev (or the equivalent for yarn and pnmp) which is wrong. The reason being is that for the scripts i.e. esbuild to correctly manage to build the extension from github we have to also pull the devDependencies, so they can be built into the lib bundle.

The implementation with --omit=dev is fine if you are pulling from npm, but it is not fine if you are building from github, am i correct to suggest that this has to be done only in case npm is used as a registry, otherwise we have to simply run npm install on the github repo, which will correctly pull all dependencies, then run the post install scripts, esbuild will bundle the devDeps in /lib/index.js and the extension should build just fine. Thanks @fannheyward

[asmodeus812]

There is also this env: Object.assign(process.env, { NODE_ENV: 'production' }) which also prevents devDependencies from being downloaded, but they are required to run the build scripts too.