From 7b6f53c9e92b6d988af8dcf8fbaf306b78730e40 Mon Sep 17 00:00:00 2001 From: Ragnar Wernersson Date: Mon, 11 Nov 2024 13:12:43 +0100 Subject: [PATCH 1/4] Add metrics for Raft Snapshots. Attempt/success/fail --- modules/ROOT/pages/monitoring/metrics/reference.adoc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modules/ROOT/pages/monitoring/metrics/reference.adoc b/modules/ROOT/pages/monitoring/metrics/reference.adoc index dac38cb76..f0cb91cee 100644 --- a/modules/ROOT/pages/monitoring/metrics/reference.adoc +++ b/modules/ROOT/pages/monitoring/metrics/reference.adoc @@ -578,6 +578,9 @@ The deprecated Raft core metrics are replaced accordingly by the Raft metrics in |.cluster.raft.replication_maybe|Raft Replication maybe count. (counter) |.cluster.raft.replication_success|The total number of Raft replication requests that have succeeded. (counter) |.cluster.raft.last_leader_message|The time elapsed since the last message from a leader in milliseconds. Should reset periodically. (gauge) +|.cluster.raft.snapshot_attempt|Downloading of Raft snapshot attempts triggered. (counter) +|.cluster.raft.snapshot_success|Downloading of Raft snapshot successful downloads. (counter) +|.cluster.raft.snapshot_fail|Downloading of Raft snapshot failed downloads. (counter) |=== From 9a97a8fe338970320b4bc5de8f0b3ee51bec613b Mon Sep 17 00:00:00 2001 From: Ragnar Wernersson Date: Tue, 19 Nov 2024 22:04:17 +0100 Subject: [PATCH 2/4] Change to gauge --- modules/ROOT/pages/monitoring/metrics/reference.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/ROOT/pages/monitoring/metrics/reference.adoc b/modules/ROOT/pages/monitoring/metrics/reference.adoc index f0cb91cee..20aa371b9 100644 --- a/modules/ROOT/pages/monitoring/metrics/reference.adoc +++ b/modules/ROOT/pages/monitoring/metrics/reference.adoc @@ -578,9 +578,9 @@ The deprecated Raft core metrics are replaced accordingly by the Raft metrics in |.cluster.raft.replication_maybe|Raft Replication maybe count. (counter) |.cluster.raft.replication_success|The total number of Raft replication requests that have succeeded. (counter) |.cluster.raft.last_leader_message|The time elapsed since the last message from a leader in milliseconds. Should reset periodically. (gauge) -|.cluster.raft.snapshot_attempt|Downloading of Raft snapshot attempts triggered. (counter) -|.cluster.raft.snapshot_success|Downloading of Raft snapshot successful downloads. (counter) -|.cluster.raft.snapshot_fail|Downloading of Raft snapshot failed downloads. (counter) +|.cluster.raft.snapshot_attempt|Downloading of Raft snapshot attempts triggered. (gauge) +|.cluster.raft.snapshot_success|Downloading of Raft snapshot successful downloads. (gauge) +|.cluster.raft.snapshot_fail|Downloading of Raft snapshot failed downloads. (gauge) |=== From 364b6273257cb4e9e6706bb0762c4d1329a43e31 Mon Sep 17 00:00:00 2001 From: Ragnar Wernersson Date: Thu, 21 Nov 2024 08:50:48 +0100 Subject: [PATCH 3/4] Revert "Change to gauge" This reverts commit 9a97a8fe338970320b4bc5de8f0b3ee51bec613b. --- modules/ROOT/pages/monitoring/metrics/reference.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/ROOT/pages/monitoring/metrics/reference.adoc b/modules/ROOT/pages/monitoring/metrics/reference.adoc index 20aa371b9..f0cb91cee 100644 --- a/modules/ROOT/pages/monitoring/metrics/reference.adoc +++ b/modules/ROOT/pages/monitoring/metrics/reference.adoc @@ -578,9 +578,9 @@ The deprecated Raft core metrics are replaced accordingly by the Raft metrics in |.cluster.raft.replication_maybe|Raft Replication maybe count. (counter) |.cluster.raft.replication_success|The total number of Raft replication requests that have succeeded. (counter) |.cluster.raft.last_leader_message|The time elapsed since the last message from a leader in milliseconds. Should reset periodically. (gauge) -|.cluster.raft.snapshot_attempt|Downloading of Raft snapshot attempts triggered. (gauge) -|.cluster.raft.snapshot_success|Downloading of Raft snapshot successful downloads. (gauge) -|.cluster.raft.snapshot_fail|Downloading of Raft snapshot failed downloads. (gauge) +|.cluster.raft.snapshot_attempt|Downloading of Raft snapshot attempts triggered. (counter) +|.cluster.raft.snapshot_success|Downloading of Raft snapshot successful downloads. (counter) +|.cluster.raft.snapshot_fail|Downloading of Raft snapshot failed downloads. (counter) |=== From 1f1c6488af6db9fa46ba9ca586c0c3ee7be0698a Mon Sep 17 00:00:00 2001 From: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com> Date: Wed, 8 Jan 2025 15:22:07 +0100 Subject: [PATCH 4/4] Apply suggestions from code review --- modules/ROOT/pages/monitoring/metrics/reference.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/ROOT/pages/monitoring/metrics/reference.adoc b/modules/ROOT/pages/monitoring/metrics/reference.adoc index f0cb91cee..ef8116145 100644 --- a/modules/ROOT/pages/monitoring/metrics/reference.adoc +++ b/modules/ROOT/pages/monitoring/metrics/reference.adoc @@ -578,9 +578,9 @@ The deprecated Raft core metrics are replaced accordingly by the Raft metrics in |.cluster.raft.replication_maybe|Raft Replication maybe count. (counter) |.cluster.raft.replication_success|The total number of Raft replication requests that have succeeded. (counter) |.cluster.raft.last_leader_message|The time elapsed since the last message from a leader in milliseconds. Should reset periodically. (gauge) -|.cluster.raft.snapshot_attempt|Downloading of Raft snapshot attempts triggered. (counter) -|.cluster.raft.snapshot_success|Downloading of Raft snapshot successful downloads. (counter) -|.cluster.raft.snapshot_fail|Downloading of Raft snapshot failed downloads. (counter) +|.cluster.raft.snapshot_attempt|Total number of attempts to download Raft snapshots triggered. (counter) +|.cluster.raft.snapshot_success|Total number of successfully downloaded Raft snapshots. (counter) +|.cluster.raft.snapshot_fail|Total number of failed Raft snapshot download attempts. (counter) |===