Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ML procs for Azure OpenAI service & AWS SageMaker Endpoints #3634

Closed
jexp opened this issue Jun 19, 2023 · 1 comment · May be fixed by #4254
Closed

Add ML procs for Azure OpenAI service & AWS SageMaker Endpoints #3634

jexp opened this issue Jun 19, 2023 · 1 comment · May be fixed by #4254
Assignees
@conker84

Comments

@jexp
Copy link
Member

jexp commented Jun 19, 2023

Probably just a config setting for the regular openai service?

in python it needs:


openai.api_type = "azure" #I use Azure OpenAI. You might need to comment if you use the non-Azure instance
openai.api_base = os.getenv('OPENAI_API_BASE')
openai.api_version = os.getenv('OPENAI_API_VERSION')
openai.api_key = os.getenv('OPENAI_API_KEY')```

For Sagemaker, figure out the endpoints via langchain?


https://api.python.langchain.com/en/latest/modules/embeddings.html#langchain.embeddings.SagemakerEndpointEmbeddings
@jexp
Copy link
Member Author

jexp commented Sep 16, 2023

Azure openai should work the same as OpenAi endpoints, they just have an extra query string for API version.

Either add a specific implementation for it, where the user can also pass in the version as config.

Or reuse the openai implementation change it to support a placeholder for {path} in the URL base-string, instead of concatenating it just at the end of the URL:

so for an MSFT API like:

https://xxx-openai.openai.azure.com/openai/deployments/xxx-gpt-35/completions?api-version=2022-12-01

consider using a base-url like:

apoc.ml.openai.url=https://xxx-openai.openai.azure.com/openai/deployments/xxx-gpt-35/{path}?api-version=2022-12-01

for openai then use

https://platform.openai.com/docs/api-reference/{path}

but still support the old way if no {path} placeholder is in the base-URL

@jexp jexp moved this to Todo in APOC Extended Larus Sep 21, 2023
vga91 added a commit that referenced this issue Dec 1, 2023
@vga91
Fixes #3634: Updated ML procs for Azure OpenAI services
38019fb
vga91 added a commit that referenced this issue Dec 1, 2023
@vga91
Fixes #3634: Updated ML procs for Azure OpenAI services
5de2761
@vga91 vga91 mentioned this issue Dec 1, 2023
Merged
vga91 added a commit that referenced this issue Dec 1, 2023
@vga91
Fixes #3634: Updated ML procs for Azure OpenAI services
e1f0687
conker84 added a commit that referenced this issue Dec 4, 2023
@vga91 @conker84
Fixes #3634: Updated ML procs for Azure OpenAI services (#3850)
db102bd 
* Fixes #3634: Updated ML procs for Azure OpenAI services

* Code clean

* added enpoint env vars

* Code clean part 2

* removed unused imports

---------

Co-authored-by: Andrea Santurbano <[email protected]>
vga91 added a commit that referenced this issue Dec 18, 2023
@vga91 @conker84
Fixes #3634: Updated ML procs for Azure OpenAI services (#3850)
805673c 
* Fixes #3634: Updated ML procs for Azure OpenAI services

* Code clean

* added enpoint env vars

* Code clean part 2

* removed unused imports

---------

Co-authored-by: Andrea Santurbano <[email protected]>
vga91 added a commit that referenced this issue Dec 18, 2023
@vga91 @conker84
Fixes #3634: Updated ML procs for Azure OpenAI services (#3850) (#3863)
0ad5ecd 
* Fixes #3634: Updated ML procs for Azure OpenAI services

* Code clean

* added enpoint env vars

* Code clean part 2

* removed unused imports

---------

Co-authored-by: Andrea Santurbano <[email protected]>
vga91 added a commit that referenced this issue Dec 19, 2023
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints
76a61b5
vga91 added a commit to vga91/neo4j-apoc-procedures that referenced this issue Dec 19, 2023
@vga91
Fixes neo4j-contrib#3634: Add ML procs for AWS SageMaker Endpoints
44bd053
vga91 added a commit that referenced this issue Dec 19, 2023
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints
5d21069
vga91 added a commit that referenced this issue Dec 19, 2023
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints
33fa660
@vga91 vga91 mentioned this issue Dec 19, 2023
Merged
vga91 added a commit that referenced this issue Dec 19, 2023
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints
178702c
vga91 added a commit that referenced this issue Dec 19, 2023
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints
3f274d4
vga91 added a commit that referenced this issue Dec 19, 2023
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints
3555eba
conker84 pushed a commit that referenced this issue Dec 20, 2023
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints (#3871)
64d9f77 
* Fixes #3634: Add ML procs for AWS SageMaker Endpoints

* fix compile problems after rebase

* fix StartupExtendedTest error with sagemaker
vga91 added a commit that referenced this issue Dec 21, 2023
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints (#3871)
773f666 
* Fixes #3634: Add ML procs for AWS SageMaker Endpoints

* fix compile problems after rebase

* fix StartupExtendedTest error with sagemaker
vga91 added a commit that referenced this issue Dec 22, 2023
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints (#3871)
433b973 
* Fixes #3634: Add ML procs for AWS SageMaker Endpoints

* fix compile problems after rebase

* fix StartupExtendedTest error with sagemaker
vga91 added a commit that referenced this issue Dec 22, 2023
@vga91 @conker84
Fixes #3634: Updated ML procs for Azure OpenAI services (#3850) (#3863)
acdff8d 
* Fixes #3634: Updated ML procs for Azure OpenAI services

* Code clean

* added enpoint env vars

* Code clean part 2

* removed unused imports

---------

Co-authored-by: Andrea Santurbano <[email protected]>
vga91 added a commit that referenced this issue Jan 10, 2024
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints (#3871)
7b8896d 
* Fixes #3634: Add ML procs for AWS SageMaker Endpoints

* fix compile problems after rebase

* fix StartupExtendedTest error with sagemaker
vga91 added a commit that referenced this issue Jan 10, 2024
@vga91 @conker84
Fixes #3634: Updated ML procs for Azure OpenAI services (#3850) (#3863)
465be98 
* Fixes #3634: Updated ML procs for Azure OpenAI services

* Code clean

* added enpoint env vars

* Code clean part 2

* removed unused imports

---------

Co-authored-by: Andrea Santurbano <[email protected]>
@jexp jexp moved this from Todo to Review in APOC Extended Larus Jan 11, 2024
@jexp jexp moved this from Review to Done in APOC Extended Larus Jan 11, 2024
@jexp jexp closed this as completed Jan 11, 2024
vga91 added a commit that referenced this issue Jan 11, 2024
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints (#3871)
353ba58 
* Fixes #3634: Add ML procs for AWS SageMaker Endpoints

* fix compile problems after rebase

* fix StartupExtendedTest error with sagemaker
vga91 added a commit that referenced this issue Jan 11, 2024
@vga91 @conker84
Fixes #3634: Updated ML procs for Azure OpenAI services (#3850) (#3863)
c8ba482 
* Fixes #3634: Updated ML procs for Azure OpenAI services

* Code clean

* added enpoint env vars

* Code clean part 2

* removed unused imports

---------

Co-authored-by: Andrea Santurbano <[email protected]>
vga91 added a commit that referenced this issue Jan 11, 2024
@vga91 @conker84
Fixes #3634: Updated ML procs for Azure OpenAI services (#3850) (#3863)…
ad8d265 
… (#3885)

* Fixes #3634: Updated ML procs for Azure OpenAI services

* Code clean

* added enpoint env vars

* Code clean part 2

* removed unused imports

---------

Co-authored-by: Andrea Santurbano <[email protected]>
vga91 added a commit that referenced this issue Jan 15, 2024
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints (#3871)
03bec14 
* Fixes #3634: Add ML procs for AWS SageMaker Endpoints

* fix compile problems after rebase

* fix StartupExtendedTest error with sagemaker
vga91 added a commit that referenced this issue Jan 17, 2024
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints (#3871) (#3884)
9d3ebf8 
* Fixes #3634: Add ML procs for AWS SageMaker Endpoints

* fix compile problems after rebase

* fix StartupExtendedTest error with sagemaker
vga91 added a commit that referenced this issue Jan 19, 2024
@vga91 @conker84
Fixes #3634: Updated ML procs for Azure OpenAI services (#3850) (#3863)…
b6d852c 
… (#3885)

* Fixes #3634: Updated ML procs for Azure OpenAI services

* Code clean

* added enpoint env vars

* Code clean part 2

* removed unused imports

---------

Co-authored-by: Andrea Santurbano <[email protected]>
vga91 added a commit that referenced this issue Jan 23, 2024
@vga91 @conker84
Fixes #3634: Updated ML procs for Azure OpenAI services (#3850) (#3863)…
d83f8d5 
… (#3885)

* Fixes #3634: Updated ML procs for Azure OpenAI services

* Code clean

* added enpoint env vars

* Code clean part 2

* removed unused imports

---------

Co-authored-by: Andrea Santurbano <[email protected]>
vga91 added a commit that referenced this issue Jan 23, 2024
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints (#3871) (#3884)
34a4d08 
* Fixes #3634: Add ML procs for AWS SageMaker Endpoints

* fix compile problems after rebase

* fix StartupExtendedTest error with sagemaker
vga91 added a commit that referenced this issue Jan 23, 2024
@vga91 @conker84
Fixes #3634: Updated ML procs for Azure OpenAI services (#3850) (#3863)…
9204fe3 
… (#3885) (#3903)

* Fixes #3634: Updated ML procs for Azure OpenAI services

* Code clean

* added enpoint env vars

* Code clean part 2

* removed unused imports

---------

Co-authored-by: Andrea Santurbano <[email protected]>
vga91 added a commit that referenced this issue Jan 23, 2024
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints (#3871) (#3884)
49c7327 
* Fixes #3634: Add ML procs for AWS SageMaker Endpoints

* fix compile problems after rebase

* fix StartupExtendedTest error with sagemaker
vga91 added a commit that referenced this issue Jan 23, 2024
@vga91
Fixes #3634: Add ML procs for AWS SageMaker Endpoints (#3871) (#3884) (…
3a66c9d 
…#3908)

* Fixes #3634: Add ML procs for AWS SageMaker Endpoints

* fix compile problems after rebase

* fix StartupExtendedTest error with sagemaker
@vga91 vga91 moved this from Done to Cherry-picked1 in APOC Extended Larus May 9, 2024
vga91 added a commit that referenced this issue Nov 27, 2024
@vga91
Fixes #3634: Updated ML procs for Azure OpenAI services (#3850)
068bd36
vga91 added a commit that referenced this issue Nov 27, 2024
@vga91
[NOID] Fixes #3634: Updated ML procs for Azure OpenAI services (#3850)
bb1f978
vga91 added a commit that referenced this issue Nov 27, 2024
@vga91
[NOID] Fixes #3634: Updated ML procs for Azure OpenAI services (#3850)
9b9a307
@vga91 vga91 mentioned this issue Nov 27, 2024
Open
vga91 added a commit that referenced this issue Nov 27, 2024
@vga91
[NOID] Fixes #3634: Updated ML procs for Azure OpenAI services (#3850)
89e6571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conker84 conker84

Labels
None yet
Projects
APOC Extended Larus
Status: Done
Milestone
No milestone
2 participants
@jexp @conker84