Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching between scenarios with the :cl debug command in the in-game console should always work without error #165

Open
cooljeanius opened this issue Jan 3, 2024 · 1 comment
Open

Switching between scenarios with the :cl debug command in the in-game console should always work without error #165

cooljeanius opened this issue Jan 3, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
1.8.0

Comments

@cooljeanius
Copy link
Collaborator

Copying this over from #163:
When skipping from S04 ("Battle of Barnon") to S05 ("The Swamp Things") with the in-game :cl command, I get:

20240103 01:29:55 info wml: A [recall] tag with the following content failed:
show = no
side = 1
x = 1
y = 1
20240103 01:29:57 error wml: [unstore_unit]: variable 'ano_reme_stored' doesn't contain unit data

We should probably check to make sure that proper cleanup happens even in debug mode. I think that Iris has some code in IftU/AtS to handle situations like this that we could look at for inspiration.
@cooljeanius cooljeanius added the bug Something isn't working label Jan 3, 2024
@cooljeanius cooljeanius mentioned this issue Jan 3, 2024
Merged
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Apr 8, 2024
@cooljeanius
Update 05_The_Swamp_Things.cfg
cd268c7 
add a TODO note about nemaara/A_New_Order#165
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue May 19, 2024
@cooljeanius
another attempt at nemaara/A_New_Order#165
c376bbd 
still doesn't work yet; FIXME
cooljeanius added a commit to cooljeanius/A_New_Order-1 that referenced this issue May 19, 2024
@cooljeanius
a number of additional minor fixes
64c0911 
- be more explicit about carryover amounts for issue #14 (still need to check scenarios 20 thru 26)
- check for Lorin's presence in Kyobaine Easter Egg for issue nemaara#150
- attempt at improving the situation for issue nemaara#165 (still broken)
- Update commentary re: issue nemaara#79
- Updates to dialogue and translation notes for issue nemaara#182
- Enables Raedwood East for normal gameplay for issue nemaara#129
- Give Lorin unique bridge destruction dialogue for issue nemaara#187
@cooljeanius cooljeanius mentioned this issue May 19, 2024
Merged
@cooljeanius
Copy link
Collaborator Author

I attempted to address this in #194 a bit, but it didn't really work...

cooljeanius added a commit that referenced this issue Aug 24, 2024
@cooljeanius
Fixes for issues targeted for Milestone 1.7.0 (#194)
db6054d 
* Start of another PR
  - Another attempt at fixing #23 again; cc @Toranks and @knyghtmare
  - Refer to Gawen as "Haldric" in S08 for #182
  - Dune is probably ok to reference explicitly by name in the translators' comments
  - try Lorin stat changes suggested in #179
* a number of additional minor fixes
  - be more explicit about carryover amounts for issue #14 (still need to check scenarios 20 thru 26)
  - check for Lorin's presence in Kyobaine Easter Egg for issue #150
  - attempt at improving the situation for issue #165 (still broken)
  - Update commentary re: issue #79
  - Updates to dialogue and translation notes for issue #182
  - Enables Raedwood East for normal gameplay for issue #129
  - Give Lorin unique bridge destruction dialogue for issue #187
* a few minor tweaks
* a few additional updates
  - add luacheck workflow
  - add a few additional changelog items
  - dialogue changes for checkbox 2 of issue #32
* Add Rob Roe death message
  - see issue #199
* some more changes from other repo
  - more spellchecking
  - use proper portrait for Kyobaine in her death message
  - tried to add a new fix for #79, but it doesn't seem to work...
  - a few more footnotes
* latest batch of changes from other repo
(squashed)
@cooljeanius cooljeanius added this to the 1.8.0 milestone Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
1 participant
@cooljeanius