ensure all units have correct portrait associated with them #16
Comments
|
PR #17 ought to fix this |
Actually, I take this back: there's still the part about Lorin getting her haircut; I'll want to use |
meant to address nemaara/A_New_Order#16 (untested)
|
I noticed another instance of a Gawen message having the wrong portrait in S12 ("Leaving Raedwood") in cooljeanius/A_New_Order@f649e24 |
This ought to be equivalent to cooljeanius/A_New_Order@43565fe..44013a3 Bugs addressed, in order of the commits in my repo addressing them: Addresses #16 (doesn't fix it entirely, though) Closes #30 Closes #18 Closes #15 Closes #31 Closes cooljeanius/A_New_Order#12 Doesn't actually do anything about #24, despite adding a comment referring to it Closes #39 Doesn't really do anything about #19, despite adding comments referring to it
ok so PR #43 ought to address that part, but...
...this part will still be an issue after that's merged, though. |
|
I might set our progress on this one back a bit once I submit Kyobaine's winter portrait, since the logic of when she gets to have it is a bit complicated... (which is part of why I haven't actually submitted it here yet, since I want to test via another playthrough) |
add new debug menu option for testing nemaara/A_New_Order#16 to just display a basic message from the unit (also other Saorduc tweaks)
|
ok so in cooljeanius/A_New_Order@2f5f98a I added a menu option to help with testing this (it basically just displays a message from a selected unit with its default portrait), and it's revealing that this issue is more widespread than I realized... |
|
I think part of the issue is that when I change the portraits for our heroes, I'm not currently using objects to do so for most of them... |
(this is now in PR #117, btw) |
- add @Toranks to the credits - new portrait for Kyobaine's winter clothing, contributed by OneHourLate, a.k.a. Mells or ohlyf (from Discord, who I also commissioned my last few portraits from) - I made an attempt at improving the issue #19 situation, but it didn't exactly work out to my liking, so it's hidden behind debug mode for now. - New debug mode contextual menu option for displaying messages from arbitrary units, for the purposes of testing issue #16 - Add a macro that I thought I'd included in #109 (and even used there), but looks like I actually forgot... (it's for giving experience to units) - New scenario! This commit includes S15c, "Raedwood East", which is probably enough to fix issue #72 for now (the scenario still isn't fully complete yet, but it's finished enough for the purposes of closing that issue) - Mark more units as unrenamable. Closes issue #114 - Adjust recruitment patterns. Closes issue #116 - fix #112 - Something for issue #7 that I thought I'd already submitted in a previous PR (but, actually hadn't)
merged in e439458; I'm going to continue tinkering with that menu option and intend to add it in more places so we can find other places where the portraits might need to be switched |
remember to use Kyobaine's proper portrait in her death message see: nemaara/A_New_Order#16
…esnoth-map-diff-9159e4e Bump utils/wesnoth-map-diff from `34a8cdb` to `9159e4e`
Currently all units with unique portraits have those unique portraits used via the macros in
macros/messages.cfg; much of the time the portraits aren't actually embedded in their unit declarations in the main scenario WML, though, which can lead to the unique portrait getting left out if the unit triggers a message intended for a generic unit. This can be fixed by ensuring all heroes with unique portraits have those portraits set via theprofile=key in their UnitWML, which I can do, but I might miss some by accident.The text was updated successfully, but these errors were encountered: