Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure all recruitment lists match up with recruitment patterns #116

Closed
cooljeanius opened this issue Mar 4, 2023 · 3 comments
Closed

ensure all recruitment lists match up with recruitment patterns #116

cooljeanius opened this issue Mar 4, 2023 · 3 comments
Assignees
@cooljeanius
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.6.0

Comments

@cooljeanius
Copy link
Collaborator

I think there are some units that AI sides have in their recruitment lists that they might not ever recruit due to not having their matching usage type listed in their recruitment patter; will need to verify...
@cooljeanius cooljeanius self-assigned this Mar 4, 2023
@cooljeanius cooljeanius added enhancement New feature or request good first issue Good for newcomers labels Mar 4, 2023
@cooljeanius cooljeanius mentioned this issue Mar 4, 2023
Open
@ProditorMagnus
Copy link

ProditorMagnus commented Mar 4, 2023 •
edited
Loading

Select [unit_type]/usage where usage is not in allow list. Example with different attribute inside unit_type https://github.com/ProditorMagnus/WML_tree_tools/blob/master/py_files/find_patterns.py#L37

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Mar 4, 2023
@cooljeanius
adjust recruitment patterns
d5b0dae 
also add comments as reminders of what usages of existing units are
see nemaara/A_New_Order#116
(untested)
@cooljeanius cooljeanius mentioned this issue Mar 4, 2023
Merged
@cooljeanius
Copy link
Collaborator Author

PR #117 ought to close this

cooljeanius added a commit that referenced this issue Mar 7, 2023
@cooljeanius
Merge pull request #117 from cooljeanius/middle_scenarios_tinkering
e439458 
- add @Toranks to the credits
- new portrait for Kyobaine's winter clothing, contributed by OneHourLate, a.k.a. Mells or ohlyf (from Discord, who I also commissioned my last few portraits from)
- I made an attempt at improving the issue #19 situation, but it didn't exactly work out to my liking, so it's hidden behind debug mode for now.
- New debug mode contextual menu option for displaying messages from arbitrary units, for the purposes of testing issue #16 
- Add a macro that I thought I'd included in #109 (and even used there), but looks like I actually forgot... (it's for giving experience to units)
- New scenario! This commit includes S15c, "Raedwood East", which is probably enough to fix issue #72 for now (the scenario still isn't fully complete yet, but it's finished enough for the purposes of closing that issue)
- Mark more units as unrenamable. Closes issue #114 
- Adjust recruitment patterns. Closes issue #116 
- fix #112 
- Something for issue #7 that I thought I'd already submitted in a previous PR (but, actually hadn't)
@cooljeanius
Copy link
Collaborator Author

Ought to be fixed by e439458

@cooljeanius cooljeanius added this to the 1.6.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cooljeanius cooljeanius

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@cooljeanius @ProditorMagnus