From 8e0df096c9f8cb92f6c110a5d251fdb2626a8f65 Mon Sep 17 00:00:00 2001
From: djordy <djordy.koert@yoursurprise.com>
Date: Fri, 1 Nov 2024 15:08:16 +0100
Subject: [PATCH] refactor: remove deprecation & thrown exception & constructor
 defaults

---
 src/ModelDescriber/FormModelDescriber.php | 24 +++++++----------------
 1 file changed, 7 insertions(+), 17 deletions(-)

diff --git a/src/ModelDescriber/FormModelDescriber.php b/src/ModelDescriber/FormModelDescriber.php
index 7b216755d..9c19611c4 100644
--- a/src/ModelDescriber/FormModelDescriber.php
+++ b/src/ModelDescriber/FormModelDescriber.php
@@ -38,7 +38,7 @@ final class FormModelDescriber implements ModelDescriberInterface, ModelRegistry
     use ModelRegistryAwareTrait;
     use SetsContextTrait;
 
-    private ?FormFactoryInterface $formFactory;
+    private FormFactoryInterface $formFactory;
     private ?Reader $doctrineReader;
 
     /**
@@ -49,23 +49,17 @@ final class FormModelDescriber implements ModelDescriberInterface, ModelRegistry
     private bool $isFormCsrfExtensionEnabled;
 
     /**
-     * @param string[]|null $mediaTypes
+     * @param string[] $mediaTypes
      */
     public function __construct(
-        ?FormFactoryInterface $formFactory = null,
-        ?Reader $reader = null,
-        ?array $mediaTypes = null,
-        bool $useValidationGroups = false,
-        bool $isFormCsrfExtensionEnabled = false
+        FormFactoryInterface $formFactory,
+        ?Reader $reader,
+        array $mediaTypes,
+        bool $useValidationGroups,
+        bool $isFormCsrfExtensionEnabled
     ) {
         $this->formFactory = $formFactory;
         $this->doctrineReader = $reader;
-
-        if (null === $mediaTypes) {
-            $mediaTypes = ['json'];
-
-            trigger_deprecation('nelmio/api-doc-bundle', '4.1', 'Not passing media types to the constructor of %s is deprecated and won\'t be allowed in version 5.', self::class);
-        }
         $this->mediaTypes = $mediaTypes;
         $this->useValidationGroups = $useValidationGroups;
         $this->isFormCsrfExtensionEnabled = $isFormCsrfExtensionEnabled;
@@ -73,10 +67,6 @@ public function __construct(
 
     public function describe(Model $model, OA\Schema $schema): void
     {
-        if (null === $this->formFactory) {
-            throw new \LogicException('You need to enable forms in your application to use a form as a model.');
-        }
-
         $class = $model->getType()->getClassName();
 
         $annotationsReader = new AnnotationsReader(