icecast env variables are not set in libretime-core container

[frecuencialibre]

out of the box, icecast variables specified in your .env file are not added to the libretime database, nor populated to liquidsoap.cfg. currently an additional step is necessary in order to get those lined up: go to Settings > Streams, and then choose "Custom / 3rd Party Streaming" and enter your info, including passwords within the "Additional Options" collapsed section.

[Robbt]

This would be something good to integrate with LibreTime in general see libretime/libretime#86 - having things work out of the box with insecure defaults is more of a bug than a feature. I know that the current docker setup bypasses the LibreTime web installer so not exactly sure of the best way to fix this on both separate instances but determining the steps could be applied to each other. Ideally we would configure the default vs requiring a custom setup.

[frecuencialibre]

how complicated would it be to add an additional step to the web installer? i'd say that rather than "bypassing" the web installer, the docker install piggybacks on it with a bunch of curl requests. see firstrun.sh

[Robbt]

Well adding a new page wouldn't be too tricky, I'd have too look into it. So if docker uses it then perhaps that is the best route. So I guess the easiest way of doing this would be a screen similar to the rabbitmq one where they are told it's best practice to edit their icecast config and then input the updated values on there.

But it would be better in terms of UI if the user didn't have to manually edit a text file from the command line because linux novices might get stuck at this step and either ignore it or mess it up and require more support.

But I'm not sure how easy it would be to propogate an edit to the icecast xml file without giving the web server write permissions to icecast and thus potentially causing a security issue. The security issue from this is probably far lower than the one of people running "hackme" as their icecast password though.

[ned-kelly]

Hi guys - Aware of this one - My plan is to write a script or patch that just dumps the configuration in the database directly (and updates the LS config files) - The hostname of the Icecast server should ideally be the internal name of the Icecast docker container that Libretime talks to - this way we don't need to ask the user for this variable.