Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The gulp incompatible node v10.0.0 #24

Open
act262 opened this issue May 2, 2018 · 4 comments
Open

The gulp incompatible node v10.0.0 #24

act262 opened this issue May 2, 2018 · 4 comments

Comments

@act262
Copy link

act262 commented May 2, 2018

Environment:
neb.js git:(master) ✗ node -v v10.0.0

gulp run abort:
gulp gulp[84896]: ../src/node_contextify.cc:631:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertionargs[1]->IsString()' failed.
1: node::Abort() [/usr/local/bin/node]
2: node::Assert(char const* const () [4]) [/usr/local/bin/node]
3: node::contextify::ContextifyScript::New(v8::FunctionCallbackInfov8::Value const&) [/usr/local/bin/node]
4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo
) [/usr/local/bin/node]
5: v8::internal::MaybeHandlev8::internal::Object v8::internal::(anonymous namespace)::HandleApiCallHelper(v8::internal::Isolate*, v8::internal::Handlev8::internal::HeapObject, v8::internal::Handlev8::internal::HeapObject, v8::internal::Handlev8::internal::FunctionTemplateInfo, v8::internal::Handlev8::internal::Object, v8::internal::BuiltinArguments) [/usr/local/bin/node]
6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node]
7: 0x18b90a18427d
8: 0x18b90a18f755
9: 0x18b90a20bc20
10: 0x18b90a1944f7
11: 0x18b90a1944f7
12: 0x18b90a1944f7
[1] 84896 abort gulp
`

Maybe official release final dist js for us ,so we don't need to build it ourself.

@ChengOrangeJu
Copy link
Contributor

Hello @act262 ,
Thanks for your information, we are looking into the issue, stay tuned :)

@ChengOrangeJu
Copy link
Contributor

Hello @act262 , Discussed with team members that dist js might not be suitable to be included in the project for the reason that it could change quite often between different commits.

@marcusjrc
Copy link

You could publish a separate npm package containing just the build code, then users could just npm install and use that directly

@1c7
Copy link
Contributor

1c7 commented Jan 18, 2019

just switch to node 8 and gulp would work
( I use n command switch to node version 8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants