Are semver comparisons broken in this library?

[peffis]

> semver:compare(semver:parse(<<"1.0.10">>), semver:parse(<<"1.0.9">>)).
-1
> semver:compare(semver:parse(<<"1.0.9">>), semver:parse(<<"1.0.8">>)).
1

Should not 1.0.10 be larger than 1.0.9, like how 1.0.9 is larger than 1.0.8?

[peffis]

Yes, it's broken. The unpack function makes some float out of the semver, like so:

unpack({semver,1,0,10,undefined}).
1.01

This does not work if you compare against, say a semver of 1.0.9 which results in 1.09.

A better comparison would be to not go the extra mile and converting to a float - just comparing the records as they are would work better so skip the unpack step and just do
{semver,1,0,10,undefined} > {semver,1,0,9,undefined} and so on...removes a bit of code also from the library...

[peffis]

I'm happy to do a PR of peffis@c25d025 if you are interested...