Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce 'remove' method for 'near_sdk::store::Lazy' collection #1238

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

ruseinov
Copy link
Collaborator

Fixes #1218

@frol
Copy link
Collaborator

frol commented Aug 12, 2024

@ruseinov Please, use Conventional Commits for PR naming, so we can simply squash and merge it. Also, please, name PRs in such a ways that the entry would make sense in the CHANGELOG (include all the context and be specific, e.g. "near_sdk::store::Lazy collection stored value" vs "Lazy values")

@race-of-sloths invite

@race-of-sloths
Copy link

@frol Thank you for calling!

@ruseinov Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

CHANGELOG.md Outdated Show resolved Hide resolved
@ruseinov ruseinov force-pushed the ru/feature/lazy-remove branch from 29c59e6 to c17310b Compare August 12, 2024 14:45
@ruseinov ruseinov changed the title [Enhancement] Introduce remove method for Lazy values. [Enhancement] Introduce "remove" method for "near_sdk::store::Lazy" collection stored value. Aug 12, 2024
@ruseinov ruseinov changed the title [Enhancement] Introduce "remove" method for "near_sdk::store::Lazy" collection stored value. [Enhancement] Introduce 'remove' method for 'near_sdk::store::Lazy' collection stored value. Aug 12, 2024
@ruseinov ruseinov changed the title [Enhancement] Introduce 'remove' method for 'near_sdk::store::Lazy' collection stored value. feat: introduce 'remove' method for 'near_sdk::store::Lazy' collection stored value. Aug 12, 2024
@ruseinov ruseinov changed the title feat: introduce 'remove' method for 'near_sdk::store::Lazy' collection stored value. feat: introduce 'remove' method for 'near_sdk::store::Lazy' collection stored values Aug 12, 2024
@ruseinov ruseinov changed the title feat: introduce 'remove' method for 'near_sdk::store::Lazy' collection stored values feat: introduce 'remove' method for a 'near_sdk::store::Lazy' collection stored value Aug 12, 2024
@ruseinov ruseinov changed the title feat: introduce 'remove' method for a 'near_sdk::store::Lazy' collection stored value feat: introduce 'remove' method for 'near_sdk::store::Lazy' collection Aug 12, 2024
@ruseinov
Copy link
Collaborator Author

@ruseinov Please, use Conventional Commits for PR naming, so we can simply squash and merge it. Also, please, name PRs in such a ways that the entry would make sense in the CHANGELOG (include all the context and be specific, e.g. "near_sdk::store::Lazy collection stored value" vs "Lazy values")

@race-of-sloths invite

Done

@ruseinov ruseinov requested a review from frol August 12, 2024 15:02
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 3

@race-of-sloths
Copy link

@frol Thank you for calling!

@ruseinov Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol frol enabled auto-merge (squash) August 12, 2024 18:50
@frol frol merged commit 3acc8a6 into master Aug 12, 2024
32 of 58 checks passed
@frol frol deleted the ru/feature/lazy-remove branch August 12, 2024 21:13
@frol frol mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Introduce the ability to remove Lazy from value it's underlying storage.
3 participants