Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update workspace version to latest #381

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

fospring
Copy link
Contributor

@fospring fospring commented Feb 3, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

update workspaces-js to latest version, and found out the reason of #372 test failed with panic message Smart contract panicked: assertion failed: Must attach 610000000000000000000 yoctoNEAR to cover storage, caused by generated account's length increased in this MR: near/near-workspaces-js@40ba120

-    const accountId = randomAccountId();

+    const accountId = `${randomAccountId('dev-', 5, 5)}.${this.accountId}`;

and format of the dev-created account example changed from dev-17818.test.near to dev-61266-44640.test.near
so the storage_desposit amunt increase from 550000000000000000000 to 610000000000000000000.

Test Plan

Related issues/PRs

Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And good finding on fixing the storage deposit. Thank!

@ailisp ailisp merged commit df7cd8f into near:develop Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants