Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework sbt_revoke_by_owner; add helper method; add unit test #93

Merged
merged 8 commits into from
Oct 3, 2023
Merged

rework sbt_revoke_by_owner; add helper method; add unit test #93

merged 8 commits into from
Oct 3, 2023

Conversation

sczembor
Copy link
Contributor

@sczembor sczembor commented Sep 29, 2023 •
edited
Loading

  • rework sbt_revoke_by_owner
  • add helper function sbt_token_ids_by_owner
  • add unit test for sbt_token_ids_by_owner
  • bug fix when revoking tokens without burning them
  • benchmark test

@sczembor sczembor requested a review from a team as a code owner September 29, 2023 11:38
robert-zaremba
robert-zaremba reviewed Sep 29, 2023
View reviewed changes
contracts/registry/src/lib.rs Outdated Show resolved Hide resolved
contracts/registry/src/lib.rs Outdated Show resolved Hide resolved
contracts/registry/src/registry.rs Outdated Show resolved Hide resolved
contracts/registry/src/registry.rs Show resolved Hide resolved
robert-zaremba
robert-zaremba approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

contracts/registry/src/lib.rs Show resolved Hide resolved
@sczembor sczembor enabled auto-merge (squash) October 3, 2023 11:40
@sczembor sczembor merged commit 1c683a9 into master Oct 3, 2023
3 checks passed
@sczembor sczembor deleted the rework_sbt_revoke_by_owner branch October 3, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sczembor @robert-zaremba