Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 5.8.3 #36

Closed
fisuri opened this issue Dec 18, 2024 · 7 comments
Closed

Update 5.8.3 #36

fisuri opened this issue Dec 18, 2024 · 7 comments
Assignees
@kaeeraa
Labels
bug Something isn't working flake-update Updates the flake configuration or dependencies good first issue Good for newcomers medium-prior Important fix or update that should be merged soon

Comments

@fisuri
Copy link
Contributor

fisuri commented Dec 18, 2024

Describe the bug

When the 5.8.6 update was committed, sha256 was not updated, I updated it in the fork, but now I'm catching a ninja compilation error

Steps To Reproduce

Steps to reproduce the behavior:

  1. use this ayugram-desktop.url = "github:/fisuri/ayugram-desktop/fix/release-5.8.6?submodules=1";
  2. home.packages = with pkgs; [
    inputs.ayugram-desktop.packages.${pkgs.system}.ayugram-desktop
    ];
  3. home-manager switch --flake

Expected behavior

normal package build

Screenshots

image

Additional context

unfortunately, I'm not good at C and C++

ayugram-desktop> ninja: build stopped: subcommand failed.
error: builder for '/nix/store/skz771r6k2ns9zmk4zvcyllrzz7lqfk1-ayugram-desktop-5.8.3.drv' failed with exit code 1;
       last 25 log lines:
       > /build/source/Telegram/lib_tl/tl/tl_basic_types.h: In member function 'void tl::double_type::write(Accumulator&) const':
       > /build/source/Telegram/lib_tl/tl/tl_basic_types.h:367:22: error: 'memcpy' is not a member of 'std'; did you mean 'wmemcpy'?
       >   367 |                 std::memcpy(&nonaliased, &v, sizeof(v));
       >       |                      ^~~~~~
       >       |                      wmemcpy
       > [496/1577] Building CXX object Telegram/CMakeFiles/td_scheme.dir/gen/scheme.cpp.o
       > FAILED: Telegram/CMakeFiles/td_scheme.dir/gen/scheme.cpp.o
       > /nix/store/vh9fsdhgxcnab2qk7vdp2palkkn6j3cp-gcc-wrapper-13.3.0/bin/g++ -DCRL_FORCE_COMMON_QUEUE -DGI_INLINE -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_56 -DKCOREADDONS_EXPORT="" -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DEPRECATED_WARNINGS_SINCE=0x051500 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_QMLMODELS_LIB -DQT_QML_LIB -DQT_QUICKWIDGETS_LIB -DQT_QUICK_LIB -DQT_SVG_LIB -DQT_WAYLANDCOMPOSITOR_LIB -DQT_WIDGETS_LIB -I/build/source/Telegram/SourceFiles -I/build/source/Telegram/lib_base -I/build/source/Telegram/lib_rpl -I/build/source/Telegram/lib_crl -I/build/source/cmake/external/glib/cppgir -I/build/source/cmake/external/glib/cppgir/gi -I/build/source/cmake/external/glib/cppgir/override -I/build/source/cmake/external/glib/cppgir/expected-lite/include -I/build/source/Telegram/lib_tl -isystem /build/source/build/Telegram/gen -isystem /build/source/Telegram/ThirdParty/GSL/include -isystem /build/source/Telegram/ThirdParty/dispatch -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/include/QtCore -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/./mkspecs/linux-g++ -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/include/QtCore/5.15.15 -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/include/QtCore/5.15.15/QtCore -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/include/QtGui -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/include/QtGui/5.15.15 -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/include/QtGui/5.15.15/QtGui -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/include/QtWidgets -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/include/QtWidgets/5.15.15 -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/include/QtWidgets/5.15.15/QtWidgets -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/include/QtNetwork -isystem /nix/store/7i508qz0dmnwnppf384sb04a02l7d34j-qtsvg-5.15.15-dev/include/QtSvg -isystem /nix/store/35n2x3dnj168hd312szccii6w028syb8-qtbase-5.15.15-dev/include/QtDBus -isystem /nix/store/b6qrfdbhx610cmmb8819p5pyh8bvgbqc-qtdeclarative-5.15.15-dev/include/QtQuick -isystem /nix/store/b6qrfdbhx610cmmb8819p5pyh8bvgbqc-qtdeclarative-5.15.15-dev/include/QtQmlModels -isystem /nix/store/b6qrfdbhx610cmmb8819p5pyh8bvgbqc-qtdeclarative-5.15.15-dev/include/QtQml -isystem /nix/store/b6qrfdbhx610cmmb8819p5pyh8bvgbqc-qtdeclarative-5.15.15-dev/include/QtQuickWidgets -isystem /nix/store/80ccmh37h494d1wmzzbb8alyqj0axy3w-qtwayland-5.15.15-dev/include/QtWaylandCompositor -isystem /nix/store/53lav9bq5liv63abwm8p9vz1v4p8xn12-tl-expected-1.1.0/share -isystem /build/source/Telegram/ThirdParty/kcoreaddons/src/lib/io -isystem /build/source/Telegram/ThirdParty/kcoreaddons/src/lib/util -isystem /build/source/cmake/external/kcoreaddons/headers/public -isystem /build/source/build/Telegram/lib_base/gen -isystem /build/source/build/gen -isystem /nix/store/82bbzzkj4ncqg1q08f9c6f91pam9kf0n-glib-2.80.4-dev/include/gio-unix-2.0 -isystem /nix/store/82bbzzkj4ncqg1q08f9c6f91pam9kf0n-glib-2.80.4-dev/include/glib-2.0 -isystem /nix/store/fxnchbq09sq279ssqdsgzigsyvp6hz06-glib-2.80.4/lib/glib-2.0/include -O3 -O3 -DNDEBUG -std=gnu++20 -fPIC -fno-strict-aliasing -pipe -Wall -Wextra -Wno-unused-parameter -Wno-switch -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-sign-compare -Wno-deprecated -MD -MT Telegram/CMakeFiles/td_scheme.dir/gen/scheme.cpp.o -MF Telegram/CMakeFiles/td_scheme.dir/gen/scheme.cpp.o.d -o Telegram/CMakeFiles/td_scheme.dir/gen/scheme.cpp.o -c /build/source/build/Telegram/gen/scheme.cpp
       > In file included from /build/source/Telegram/SourceFiles/mtproto/core_types.h:16,
       >                  from /build/source/build/Telegram/gen/scheme.h:6,
       >                  from /build/source/build/Telegram/gen/scheme.cpp:4:
       > /build/source/Telegram/lib_tl/tl/tl_basic_types.h: In member function 'bool tl::double_type::read(const Prime*&, const Prime*, uint32)':
       > /build/source/Telegram/lib_tl/tl/tl_basic_types.h:360:22: error: 'memcpy' is not a member of 'std'; did you mean 'wmemcpy'?
       >   360 |                 std::memcpy(&v, &nonaliased, sizeof(v));
       >       |                      ^~~~~~
       >       |                      wmemcpy
       > /build/source/Telegram/lib_tl/tl/tl_basic_types.h: In member function 'void tl::double_type::write(Accumulator&) const':
       > /build/source/Telegram/lib_tl/tl/tl_basic_types.h:367:22: error: 'memcpy' is not a member of 'std'; did you mean 'wmemcpy'?
       >   367 |                 std::memcpy(&nonaliased, &v, sizeof(v));
       >       |                      ^~~~~~
       >       |                      wmemcpy
       > [497/1577] Building CXX object Telegram/lib_spellcheck/CMakeFiles/lib_spellcheck.dir/spellcheck/third_party/hunspell_controller.cpp.o
       > [498/1577] Building CXX object Telegram/lib_webview/CMakeFiles/lib_webview.dir/webview/platform/linux/webview_linux_webkitgtk.cpp.o
       > [499/1577] Building CXX object Telegram/CMakeFiles/td_lang.dir/gen/lang_auto.cpp.o
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/skz771r6k2ns9zmk4zvcyllrzz7lqfk1-ayugram-desktop-5.8.3.drv'.
error: 1 dependencies of derivation '/nix/store/klacm2lm1dgcqndidi9m3d7dr5lasl8m-home-manager-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/89k5nsw91281m8xy8p3iwq72wyq2zlxz-home-manager-generation.drv' failed to build

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

➜  dotfiles git:(nixos) ✗ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.12.5, NixOS, 24.11 (Vicuna), 24.11.20241216.3945713`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.24.10`
 - channels(root): `"nixos-24.11"`
 - nixpkgs: `/nix/store/wj2qla569hnxwqfc26imv5hqbxc1rc27-source`

Add a 👍 reaction to issues you find important.
@github-actions GitHub Actions
Copy link
Contributor

Hello! This is your first issue. Note that we respect everyone who writes in here

@fisuri fisuri changed the title Update 5.8.6 Update 5.8.3 Dec 18, 2024
@kaeeraa kaeeraa added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers flake-update Updates the flake configuration or dependencies medium-prior Important fix or update that should be merged soon labels Dec 18, 2024
@kaeeraa kaeeraa self-assigned this Dec 18, 2024
@kaeeraa
Copy link
Collaborator

kaeeraa commented Dec 18, 2024

I'll cancel merge from masetr and will lookup for this error

@fisuri
Copy link
Contributor Author

fisuri commented Dec 18, 2024 •
edited
Loading

it was possible to build and run with this patch

@fisuri
Copy link
Contributor Author

fisuri commented Dec 18, 2024

I think we can test it and send a pr

@fisuri fisuri mentioned this issue Dec 18, 2024
Merged
kaeeraa added a commit that referenced this issue Dec 19, 2024
@fisuri @kaeeraa
@s0me1newithhand7s @github-actions
Fix release 5.8.3 (#38)
6b89d8c 
fix this issue #36

---------

Co-authored-by: Kaeeraa <[email protected]>
Co-authored-by: hand7s <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kaeeraa kaeeraa removed the help wanted Extra attention is needed label Dec 20, 2024
@kaeeraa kaeeraa closed this as completed Dec 20, 2024
@kaeeraa kaeeraa reopened this Dec 20, 2024
@kaeeraa
Copy link
Collaborator

kaeeraa commented Dec 20, 2024

nvm

@kaeeraa
Copy link
Collaborator

kaeeraa commented Dec 30, 2024

I'm ready to release v5.8.6 tomorrow

@s0me1newithhand7s
Copy link
Collaborator

I'm ready to release v5.8.6 tomorrow

.. or not

@kaeeraa kaeeraa closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaeeraa kaeeraa

Labels
bug Something isn't working flake-update Updates the flake configuration or dependencies good first issue Good for newcomers medium-prior Important fix or update that should be merged soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fisuri @kaeeraa @s0me1newithhand7s