Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radio locator id should not include fleet# prefix #610

Closed
Tracked by #543
caver456 opened this issue Dec 20, 2022 · 2 comments
Closed
Tracked by #543

radio locator id should not include fleet# prefix #610

caver456 opened this issue Dec 20, 2022 · 2 comments

Comments

@caver456
Copy link
Collaborator

Not sure if this issue is new or old, that is, not sure whether it's due to the way Shared Locations processes the label, or, whether the issue has been around for a long time and was also causing label problems when Locator Group was handling the requests. Regardless: right now the rest/location/update request is getting sent with the id syntax like so:

064855:http://localhost:8080/rest/location/update/position?lat=39.268845&lng=-121.02551833333334&id=FLEET:100-Team abc

which results in a label '100-Team abc' when viewing Shared Locations:

image

All of this will be revisited as a part of #598 - see tasks and comments regarding labels in that issue - but, this portion can be addressed right now as its own issue.

(Unfortunately there's probably not a way to change the label of an existing Shared Location dot, so, the original 'device-id' Shared Location dot before Change Callsign will remain. Maybe need to reinvestigate NOT sending until after CCD. Right now, it is sent before CCD as a safety measure, so the location can be seen right away, in case CCD is not completed for some time. Opened a caltopo help ticket to find out of it's possible to change the name of an existing Shared Location dot, or to delete an existing Shared Location dot.)

@caver456
Copy link
Collaborator Author

Need to check if sending without the 100- will still work for LiveTracks. Also, omitting the 100- will probably cause it to fail for old CTD using Locator Groups. Maybe the better route is to submit a help ticket asking to automatically prune the fleet# from the Shared Location label, if FLEET: is part of the sent request id.

@caver456
Copy link
Collaborator Author

caver456 commented Aug 5, 2023

closing this issue since it's now part of #598

@caver456 caver456 closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant