Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Remove direct dependence on ced2ar-rdb #1

Open
2 tasks
bbarker opened this issue Oct 2, 2018 · 1 comment
Open
2 tasks

Remove direct dependence on ced2ar-rdb #1

bbarker opened this issue Oct 2, 2018 · 1 comment

Comments

@bbarker
Copy link
Collaborator

bbarker commented Oct 2, 2018

There are a number of cases where ced2ar-rdb is a direct dependency of this project, and really it should not be the case. Instead, layers of indirection should be added, where appropriate, to ced2ar-core-services (or another services module).

  • Remove dependencies by adding to services modules and refactoring.
  • Remove dependency on cedar3-rdb in pom.xml
@bbarker
Copy link
Collaborator Author

bbarker commented Oct 2, 2018

Quick scan using ripgrep returns a few cases of interest (some of these are false positives and may refer to the controller model):

src/main/resources/META-INF/persistence.xml
4:              <class>edu.ncrn.cornell.model.Field</class>
5:              <class>edu.ncrn.cornell.model.FieldIndice</class>
6:              <class>edu.ncrn.cornell.model.FieldIndicePK</class>
7:              <class>edu.ncrn.cornell.model.FieldInst</class>
8:              <class>edu.ncrn.cornell.model.Mapping</class>
9:              <class>edu.ncrn.cornell.model.MappingPK</class>
10:             <class>edu.ncrn.cornell.model.Metadata</class>
11:             <class>edu.ncrn.cornell.model.Profile</class>
12:             <class>edu.ncrn.cornell.model.ProfileField</class>
13:             <class>edu.ncrn.cornell.model.RawDoc</class>
14:             <class>edu.ncrn.cornell.model.Schema</class>
15:             <class>edu.ncrn.cornell.model.SchemaPK</class>

src/test/java/edu/ncrn/cornell/ced2ar/model/Ced2arRepositoryIT.scala
1:package edu.ncrn.cornell.ced2ar.model
4:import edu.cornell.ncrn.ced2ar.model.testing.BaseRepositoryIT

src/main/scala/edu/cornell/ncrn/ced2ar/site/ApplicationStartup.scala
6:import edu.cornell.ncrn.ced2ar.model.testing.DBChecker

src/main/scala/edu/cornell/ncrn/ced2ar/site/controller/DocsController.scala
5:import edu.cornell.ncrn.ced2ar.model.dao.MappingDao

src/main/scala/edu/cornell/ncrn/ced2ar/site/controller/SchemaMapController.scala
9:import edu.cornell.ncrn.ced2ar.model.{Field, Schema}
10:import edu.cornell.ncrn.ced2ar.model.dao.MappingDao

src/main/scala/edu/cornell/ncrn/ced2ar/site/view/SchemaMapView.scala
5:import edu.cornell.ncrn.ced2ar.model.{Field, Schema}

src/main/scala/edu/cornell/ncrn/ced2ar/site/view/common/Ced2arView.scala
114:    this.model = Some(model)
brandon@beb82dell0-DevContainer:~/workspace/ced2ar-site
$ 

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant