ld: unknown option: -Bstatic on macOS (fix included!)

[tseemann]

Even with GNU g++, you can't mix static and dyn libs?

c++ -std=c++11 -o skesa skesa.o glb_align.o -Wl,-Bstatic -L /usr/local/opt/boost/lib -lboost_program_options -lboost_iostreams -lboost_regex -lboost_timer -lboost_chrono -lboost_system -Wl,-Bdynamic -lrt -ldl -lm  -lpthread -lz
ld: unknown option: -Bstatic
collect2: error: ld returned 1 exit status

Seems so:
https://stackoverflow.com/questions/8910908/g-linker-does-not-recognize-bstatic

[tseemann]

I modified Makefile.nongs to do this:

PLATFORM=$(shell uname -s)

ifeq ($(PLATFORM),Linux)

LIBS = -Wl,-Bstatic $(BOOST_LIB) \
       -lboost_program_options \
       -lboost_iostreams \
       -lboost_regex \
       -lboost_timer \
       -lboost_chrono \
       -lboost_system \
       -Wl,-Bdynamic -lrt -ldl -lm  -lpthread -lz

else

LIBS = $(BOOST_LIB) \
       -lboost_program_options \
       -lboost_iostreams \
       -lboost_regex \
       -lboost_timer \
       -lboost_chrono \
       -lboost_system \
       -ldl -lm -lpthread -lz

endif

[tseemann]

This is still a bug.

[souvorov]

Sorry, I forgot about this one. Done.

[souvorov]

Is there any simple way to include last changes in 2.4.0 release without making a new release?

[tseemann]

Nope. That's what 2.4.1 is for :-)
Don't worry about it yet, i think there are more problems.
Struggling to build it on MacOS now with newer boost.

[souvorov]

I can build on Linux with BOOST 1.72 without problems.

[tseemann]

Yes, Linux is not a problem. MacOS is the problem. On MacOS we need to use clang as we need to link against a clang compiled boost. can't mix gcc and clang there unfortunately.