Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled exception breaks offline PWA #15

Open
jashmore opened this issue May 13, 2021 · 1 comment
Open

Unhandled exception breaks offline PWA #15

jashmore opened this issue May 13, 2021 · 1 comment
Labels
bug Something isn't working up-for-grabs

Comments

@jashmore
Copy link

We have a Blazor app which is designed to be used offline under certain circumstances. The BrowserHttpSink.EmitBatchAsync method is not exception safe, so when it is offline, the call to _httpClient.PostAsync throws an unhandled exception which breaks the app.

@nblumhardt
Copy link
Owner

Thanks for the heads-up 👍 - not sure where/how the problem will be, the base PeriodicBatchingSink should be catching and suppressing these:

https://github.com/serilog/serilog-sinks-periodicbatching/blob/dev/src/Serilog.Sinks.PeriodicBatching/Sinks/PeriodicBatching/PeriodicBatchingSink.cs#L229

Investigation help/PRs welcome, if anyone has time to check it out

@nblumhardt nblumhardt added bug Something isn't working up-for-grabs labels May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working up-for-grabs
Projects
None yet
Development

No branches or pull requests

2 participants