CI,make.fsx: upload a nuget package #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use beta version because we use NativeSegwit (0.9 instead of 0.7, like the beta snap).
knocte
force-pushed
the
wip/nugetPkg
branch
3 times, most recently
from
517d672 to
986c70a
Compare
This way we catch potential issues with the non-prerelease nuget package before the git tag is pushed. For example, the following warning: ``` /usr/lib/dotnet/sdk/6.0.127/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "Fsdk [0.6.0--date20230530-1155.git-3bb8d08, )" or update the version field in the nuspec. [/__w/geewallet/geewallet/src/GWallet.Backend/GWallet.Backend.fsproj] ``` So let's enable 'warnaserror' in the 'dotnet pack' command if the version to pack is even (e.g. 0.8) and ignore the warning for now if it's odd (e.g. 0.7) like it currently happens. Because even numbers map to "stableness" and odd numbers to the opposite.
knocte
force-pushed
the
master
branch
2 times, most recently
from
b841302 to
ccb1641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.