Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division-by-zero error on /liquidity page #295

Closed
aahna-ashina opened this issue Aug 21, 2024 · 4 comments
Closed

Division-by-zero error on /liquidity page #295

aahna-ashina opened this issue Aug 21, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@aahna-ashina
Copy link
Member

aahna-ashina commented Aug 21, 2024

Mainnet: https://app.nation3.org/liquidity

Error: division-by-zero [ See: https://links.ethers.org/v5-errors-NUMERIC_FAULT-division-by-zero ] (fault="division-by-zero", operation="div", code=NUMERIC_FAULT, version=bignumber/5.7.0)
    at d.makeError (_app-62be13e85bce729f.js:1:113213)
    at d.throwError (_app-62be13e85bce729f.js:1:113333)

Sepolia: https://app-sepolia.nation3.org/liquidity

@aahna-ashina aahna-ashina added the bug Something isn't working label Aug 21, 2024
@brymut
Copy link
Contributor

brymut commented Aug 21, 2024

Hi @aahna-ashina, could you please confirm that this issue reproducable on sepolia? Not coming up on my end.

Edit: Seems to be a value being returned on mainnet is 0 which isn't being handled.

Please have a look at: #296

@brymut brymut mentioned this issue Aug 21, 2024
3 tasks
@aahna-ashina
Copy link
Member Author

aahna-ashina commented Aug 22, 2024

could you please confirm that this issue reproducable on sepolia? Not coming up on my end.

@brymut The app is only crashing on Mainnet. The bug exists on both Mainnet and Sepolia, but triggers only under certain conditions.

@brymut
Copy link
Contributor

brymut commented Aug 22, 2024

could you please confirm that this issue reproducable on sepolia? Not coming up on my end.

@brymut The app is only crashing on Mainnet. The bug exists on both Mainnet and Sepolia, but triggers only under certain conditions.

Ahh right, is the solution working out? @aahna-ashina

@aahna-ashina
Copy link
Member Author

#296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants